ComputerCraft

ComputerCraft

21M Downloads

1.77 Errors in set program.

Wojbie opened this issue · 3 comments

commented

Duplicated error report from : http://www.computercraft.info/forums2/index.php?/topic/25682-mc-189cc-177-settings-program-bug/
Due to 2 small errors in set program it will always save even if data was not changed because it gets invalid data and it will unset value instead of setting it to false because of wrong test used.
Problem lies in lines 31-32
They are:

local oldValue = settings.get( sValue )
if value then

And should be

local oldValue = settings.get( sName )
if value ~= nil then
commented

Grr. Wish this had been reported during beta testing.
Will be fixed in 1.78

commented

I admit to feeling embarrassed about this one. I was playing with it quite lot and it missed me too.
Also 2nd thing i just noticed:
In line 6 of set program you are using print instead of textutils.pagedPrint. That means if there are more settings then screen lines only last ones will be visible? Not sure if bug just pointing that out.
Also does fixed in 1.77 mean you are doing ghost fix? :D

commented

Means a typo!
On 16 Jan 2016 19:48, "Wojbie" [email protected] wrote:

I admit to feeling embarrassed about this one. I was playing with it quite
lot and it missed me too.
Also 2nd thing i just noticed:
In line 6 of set program you are using print instead of
textutils.pagedPrint. That means if there are more settings then screen
lines only last one will be visible? Not sure if bug just pointing that out.
Also does fixed in 1.77 mean you are doing ghost fix? :D


Reply to this email directly or view it on GitHub
#85 (comment)
.