Configured

Configured

33M Downloads

Configured bypasses Forge's configuration validation system

FireController1847 opened this issue · 2 comments

commented

Hey there,

I don't have much experience with Forge's validation system for configurations, but all I know is that it does have one. It appears that there are no checks run when modifying a config with this mod.

See #15 for an example of how this can go wrong. If the mod somehow configures a configuration improperly, there are no safety checks to ensure that it retains the correct types. Conversely, when modifying the file during runtime or before launch, Forge runs a type-check on all configuration options and if they're invalid or cannot be parsed, resets the config.

Unsure if this is intentional or not, just wanted to report it to make you aware of it.

commented

This issue has now been fixed. I was unable to test with your mod which I am sure you are aware why.

commented

Thanks a ton, I'll be sure to do some testing on my own end once I make that fix.