Consecration (Fabric/Forge/Quilt)

Consecration (Fabric/Forge/Quilt)

481k Downloads

[Feature]: Iron's Spells 'n Spellbooks Compat

Niconoko opened this issue ยท 7 comments

commented

What is the new feature or improvement?

https://www.curseforge.com/minecraft/mc-mods/irons-spells-n-spellbooks
The mod got holy spells and them seem to not work when shooting undead.

commented

You do this by editing the config, example for 1.19.2:

Damage source: https://github.com/iron431/Irons-Spells-n-Spellbooks/blob/f9f259bae4b1c3514dfc7cad9c74c5001f3c901f/src/main/java/io/redspace/ironsspellbooks/spells/SpellType.java#L326

Config:

holyDamage = ["holy", "guiding_bolt_spell", "wisp_spell"]

For 1.20.x it seems to use school types https://github.com/iron431/Irons-Spells-n-Spellbooks/blob/49f6d7619d4a4ded27404e9606a405b32f91bb17/src/main/java/io/redspace/ironsspellbooks/datagen/DamageTypeTagGenerator.java#L18

Excuse me, I don't quite get it as to 1.20.x ones. I only find holyMaterials =["silver"] in config. And how to add Iron's spell things?

commented

https://github.com/illusivesoulworks/consecration/blob/1.20.x/common/src/main/resources/data/consecration/tags/damage_type/holy.json

I wrote like this
{
"replace": false,
"values": ["consecration:holy", "irons_spellbooks:holy_magic", "holy_magic"]
}
But it didn't work

commented

check your log, adding just "holy_magic" likely broke the tag because that value doesnt exist

commented

check your log, adding just "holy_magic" likely broke the tag because that value doesnt exist

i've created small mod like this

@SubscribeEvent
    public void test(LivingAttackEvent event){
        if (event.getSource().getMsgId() != "inWall") {
            var damage = event.getSource().getMsgId();
            var z = event.getSource().getLocalizedDeathMessage(event.getEntity()).getString();
            String stri = damage + " }}}}}}}}}} " + z;
            System.out.println(stri);
        }
    }

and it returned me value: irons_spellbooks.guiding_bolt that worked

commented

perhaps, it will work same with all others spells