Autoforge does not repair armor when on fire
LordHellscream opened this issue · 8 comments
Versions (Be specific, do not write "latest"):
- Construct's Armory: 0.0.21-rc1
- Tinkers' Construct: 1.12.2-2.10.1.84
- Mantle: 1.3.2.24
- Forge: 14.23.4.2707
Observed Behavior:
Magma slime armor doesn't repair damage: it seems like the armor simply doesn't take damage from fire, but it doesn't actually "rapair" itself as described.
So it not useful at all, since first of all the player need to hurt himself to jump into the fire, and even if the fire doesn't really damage the armor, it doesn't do anything positive.
At the end of the day, you lose HP (to get yourself on fire) but gain nothing.
Expected Behavior:
The armor should have a net-positive gain on armor HP when player is on fire. (essentially trading HP for repair like parasitic modifier)
Steps to Reproduce:
- magma slime armor, steel plate, netherrack trim (full suit of armor or at least 2 pieces)
- do some damage to the armor
- make a fire with netherrack and flint and steel, sit on the fire and monitor the HP of the armor.
...
Crash Log: Please use a paste site like gist.
The actual behavior that I'm seeing is that it does repair damage, but only when you're standing directly in the fire. This is because damage while you're IN fire is subject to armor protection and calls the necessary armor damaged method, but damage while you're ON fire bypasses armor and skips the check. I'll fix this in the next update.
it's not true, i was standing in fire the whole time. the behavior is exactly the same (armor HP doesn't change)
In the future, please refrain from saying "it's not true" in reference to observed behavior. Differences in observations do not necessarily imply any sort of falsehood from either party. This is what I see, following your reproduction steps exactly.
this is very strange, i am doing the exact same thing and the HP does not recover (or go down).
One thing that may be different is that i was wearing full set of armor (exactly same settings). Not sure if that make a difference or not.
It's possible. Either way, I changed the code for this behavior in the dev build already so try it out once I can push out a new update.
Ok i did some additional testing, as I suspected, when wearing a full suit, the HP doesn't change anymore. but just wearing one piece of armor by itself it does get repair like you have shown in the gif.
Okay, I'll make sure to test this behavior before pushing out the next update.