Custom block layers apply to solid blocks and legacy packs use weight property incorrectly
Sweenus opened this issue · 5 comments
Using the conquest_ resource pack on both 1.18.2 and 1.19 with continuity isn't connecting all intended textures, and is causing transparency issues with grass blocks (less so with shaders enabled). Is the conquest_ using optifine features that just aren't supported by continuity, and if so, will they be supported in future? Examples below (All examples have the two optional continuity packs enabled):
Image 1
Resource pack: Conquest_
Mods: Continuity
-Partial connected texture issues
-Transparent grass blocks
Image 2
Resource Pack: Conquest_
Mods: Continuity, Sodium, Indium
-Partial connected texture issues
-Severe Transparent grass blocks
Image 3
Resource Pack: Conquest_
- Shaders enabled via Iris
Mods: Continuity, Sodium, Indium, Iris
-Partial connected texture issues
-Slight transparent grass blocks (hard to see in the image, but the edges of some grass textures are still transparent)
Image 4
Resource Pack: Conquest_
Mods: Optifine, Optifabric
This is how it should look - grass & sand connection working. No transparency.
Image 5
Resource pack: John Smith
Mods: Continuity
This resource pack connects fine - probably not using advanced optifine features
Image 6
Resource pack: Yuushya
Mods: Continuity
This resource pack connects fine - probably not using advanced optifine features
The sand/grass is just one example. The texture connections are off for a variety of blocks.
This is not related to "advanced Optifine features". Continuity supports all CTM features. The transparency bug is caused by Continuity not checking for a full cube when when applying custom block layers from block.properties. You will see that disabling the custom block layers option in the Continuity configuration fixes the issue. This will be fixed for 2.0.2.
The sand overlay problem is separate and is caused by some very minor parity difference in the CTM code that I may or may not be able to find and fix.
I found the cause of the overlay issue some time ago so I will put it here as well. Continuity supports the weight property from MCPatcher while Optifine does not, but because the pack is so old and was never rewritten, it still has weights in some files that do nothing on Optifine but cause issues on Continuity because no one has actually tested the pack with those weights re-enabled. Clearly this property will need to be disabled by default to fix this, but I have not yet decided how to allow packs to re-enable it.
The first part of this issue has been fixed in 19821bc.
