Controlify

Controlify

609k Downloads

[Bug] Having Controlify clientside forces it for LAN/E4MC servers

Madis0 opened this issue ยท 1 comments

commented

Current Behaviour

Having Controlify on the host's client forces it on LAN/E4MC/similar servers too

Expected Behaviour

Do not require it from others

Screenshots

No response

Reproduction Steps

  1. Get Controlify
  2. Open a singleplayer world
  3. Host it on LAN
  4. Tell a vanilla client to join
  5. The joiners get java.lang.IndexOutOfBoundsException

Logs

No response

Mod Version

2.0.0-beta.13 for 1.21

Controller

issues

Bluetooth

  • Yes

Operating System

Windows

ARM

  • Yes

Additional Information

  • You are already aware of the issue, but I didn't see a bug report
  • The issue was not present in previous versions of Controlify
  • I did not actually confirm it happening on LAN-worlds yet, but was able to confirm E4MC

Just to make sure...

  • I have made sure I am using the latest version of Controlify for the latest version of Minecraft.
  • I have made sure there are no other issues describing the same problem on the issue tracker.
commented

The issue was the handshake code tried to decode the packet before it checked it was understood by the client, attempting a buffer overflow on packet reading (since it was empty).

This has been resolved and will be available in beta 14