Race Condition between ColorEvent and Objectholders can cause client crashes
Tfarcenim opened this issue ยท 6 comments
crash report: https://hatebin.com/qmbpqeedcz
Due to the nature of how modloading works, it's impossible to guarantee that all objectholders are filled in before the coloring events are called which leads to the above crash.
A workaround could be done by moving the color setup to clientsetupevent and just using mc.getColors since it's identical to the object used in the event and is guaranteed to be after all objectholders are filled in.
I'm not using ObjectHolders, and if there's a race condition between block registration and color event that's a Forge bug, since the event is supposed to specifically be fired "at the right time". Is there an open issue for that somewhere?
There's a closed issue for it: MinecraftForge/MinecraftForge#5862
forge-28.1.106 (latest atm)
CookingForBlockheads_1.14.4-7.4.1.jar
Having the same issue. Crashlog: https://hatebin.com/khyrjgajsu
Someone on the Forge issue suggests this may be happening due to another silent crash earlier on in mod loading. Do you have a full latest.log file?
Yeah, it was wrong value (mistype) in pickletweaks' config. Didn't know silent crashes is a thing, thanks!