Hello! As of 1.18 onward, it seems Copper's Delight's override for the Hunt and Gather advancement is using an outdated syntax, which causes any item to be a valid trigger for it, as opposed to just knives.

It's easy to miss without datagen, but in 1.18, item conditions are just arrays of strings, without keys or curly braces.

Outdated syntax:

"copper_knife": {
  "trigger": "minecraft:inventory_changed",
  "conditions": {
    "items": [
      {  
        "item": "coppersdelight:copper_knife" // remove "item":
      }  // remove curly braces
    ]
  }
}

New syntax:

"copper_knife": {
  "trigger": "minecraft:inventory_changed",
  "conditions": {
    "items": [
      "coppersdelight:copper_knife"
    ]
  }
}

Hope it helps! ^^

Hello! As of 1.18 onward, it seems Copper's Delight's override for the Hunt and Gather advancement is using an outdated syntax, which causes any item to be a valid trigger for it, as opposed to just knives.

It's easy to miss without datagen, but in 1.18, item conditions are just arrays of strings, without keys or curly braces.

Outdated syntax:

"copper_knife": {
  "trigger": "minecraft:inventory_changed",
  "conditions": {
    "items": [
      {  
        "item": "coppersdelight:copper_knife" // remove "item":
      }  // remove curly braces
    ]
  }
}

New syntax:

"copper_knife": {
  "trigger": "minecraft:inventory_changed",
  "conditions": {
    "items": [
      "coppersdelight:copper_knife"
    ]
  }
}

Hope it helps! ^^

Hey, thanks for letting me know of this issue. One question though:
It seems your latest code for Farmer's Delight is using the same outdated syntax? This is where I got the advancement to override from, so is this something you plan on fixing in the main mod? I will update Copper's Delight, but I want it to match the format of the original.

It seems JSON Diff tricked my eyes, and I got it wrong. My bad... 😓

The actual new syntax involves an "items" array inside the original "items" array, and is the one FD is using right now. The "item" key isn't read anymore, which makes MC treat it as an empty condition. It's a weird change, to be honest. x)

"flint_knife": {
  "trigger": "minecraft:inventory_changed",
  "conditions": {
    "items": [
      {
        "items": [
          "farmersdelight:flint_knife"
        ]
      }
    ]
  }
},

Thank you, I've updated the syntax now.