Create: Copycats+

Create: Copycats+

10M Downloads

[Bug] Crash when passing null to the appearance api pos

Closed this issue ยท 2 comments

commented

Describe the bug
Not my crash but came across it. It seems there's a crash due to the neoforge appearance api can have a null blockpos here. But this check here doesn't take that into account, causing a crash when looking for a BE.

To Reproduce
Steps to reproduce the behavior:
Install monocle (and embeddedium + iris), and look at a copycat block with shaders on.

Expected behavior
Not crash

Desktop (please complete the following information):

  • Minecraft Version: 1.21.1
  • Mod Loader neoforge
  • Mod Version

Additional context
Log.

commented

also, queryPos is nullable here and is being used directly in a method call that is not nullable and will throw a NPE

commented

Fixed. Thanks for the report