Prevents server shutdown when used alongside Create mod
simeonpfeiffer opened this issue · 32 comments
Minecraft 1.20.1
Fabric Loader 0.16.2 Launcher 1.0.1
Create 0.5.1f
Fabric API 0.92.2
Owo lib 0.11.2
CorgiLib 4.0.2.0
This minimal setup will prevent the server from shutting down after issuing the stop command.
The console will freeze after these lines:
[18:45:36] [Server thread/INFO]: Stopping the server
[18:45:36] [Server thread/INFO]: Stopping server
[18:45:36] [Server thread/INFO]: Saving players
[18:45:36] [Server thread/INFO]: Saving worlds
[18:45:40] [Server thread/INFO]: Saving chunks for level 'ServerLevel[name]'/minecraft:overworld
[18:45:41] [Server thread/INFO]: ThreadedAnvilChunkStorage (name): All chunks are saved
[18:45:41] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
The process will not terminate. There is no error message.
Came here because of this same issue as well! Can't use these mods together without killing the server which is risky.
Same here, server unload freezes after these lines:
[01:11:50] [Server thread/INFO]: Stopping the server
[01:11:50] [Server thread/INFO]: Stopping server
[01:11:50] [Server thread/INFO]: Saving players
[01:11:50] [Server thread/INFO]: Saving worlds
[01:11:50] [Server thread/INFO]: Saving chunks for level 'ServerLevel[world]'/minecraft:overworld
[01:11:50] [Server thread/INFO]: ThreadedAnvilChunkStorage (world): All chunks are saved
[01:11:50] [Server thread/INFO]: ThreadedAnvilChunkStorage: All dimensions are saved
[01:11:51] [pool-2-thread-1/INFO]: Unloading server config for airhop
When using CorgiLib 1.20.1-4.0.3.2. with the following loaded:
- fabric-server-mc.1.20.1-loader 0.16.4-launcher.1.0.1
- Fabric API 0.92.2
- ForgeConfigAPIPort-v8.0.0-1.20.1-Fabric
- PuzzlesLib-v8.1.23-1.20.1-Fabric
- AirHop-v8.0.2-1.20.1-Fabric
Substituting any one of these below for AirHop-v.8.0.2 also causes the issue:
- BarteringStation-v8.0.0-1.20.1-Fabric
- BetterTridents-v8.0.1-1.20.1-Fabric
- TradingPost-v8.0.2-1.20.1-Fabric
Any update on this? I really want to open a server but this issue is preventing me from doing so since I can't have proper restarts...
It's disappointing. I really wanted to use Oh The Biomes We've Gone as the worldgen but if this isn't fixed soon, I'll have to switch to something else.
When's the latest download gonna be available? i have the (as of writing this) latest ver from curse/modrinth, 4.0.3.2 and i'm having this same issue. Although i'm not using Create mod
Another person having the same issue but from Reddit: https://www.reddit.com/r/admincraft/comments/1gi9nn9/is_this_safe_server_not_turning_off_properly/?share_id=gtbjlojzt5QhTql9Yaq0W&utm_content=1&utm_medium=android_app&utm_name=androidcss&utm_source=share&utm_term=1
reproduced the issue in a absolute minimal configuration
https://mclo.gs/BXxX5mm
List of mods:
Corgilib-Fabric-1.20.1-4.0.3.2.jar
create-fabric-0.5.1-f-build.1417+mc1.20.1.jar
fabric-api-0.92.2+1.20.1.jar
fabric loader:
fabric-server-mc.1.20.1-loader.0.16.9-launcher.1.0.1.jar
Another person having the same issue but from Reddit: https://www.reddit.com/r/admincraft/comments/1gi9nn9/is_this_safe_server_not_turning_off_properly/?share_id=gtbjlojzt5QhTql9Yaq0W&utm_content=1&utm_medium=android_app&utm_name=androidcss&utm_source=share&utm_term=1
this is me, now my server isnt saving at all when turning off, its getting stuck on saving worlds.
latest.log
@Coolkc456 if I was paid to work on these mods I would prioritize this but I've been unfortunately swamped with things outside of this issue. Secondly I've checked the issue out but couldn't find the root cause of what causes the server to hang. Thirdly anyone can fork and make a PR with the fix for this if they do find the issue. Or uploaded their own fix to curseforge/modrinth but they'd be silly doing that but it can be done bc of the license.
It's been 3 months since the developer has responded to this issue. I am really trying to be polite, but we're being left in the dark on if this bug is even being actively worked on and it's becoming increasingly frustrating. I have considered switching to a different world gen mod, but I've already done so much work on my world prior to discovering the issue and I really want to like this mod if I can run it properly. This bug is extremely inconvenient for me and a few others I've talked to about it. I'm pretty much begging for some sort of update to the situation. Perhaps after the holidays have passed? Thanks.
I'm putting a bounty on this whoever fixes it gets 100€ from me
PayPal or Revolut
You could probably find out what's causing it using a java thread profiler pretty easily
Err... true, but I'm sure Corgi has rules against decompiling/modifying his code. Might wanna check with him for permission first. As frustrated as I am with the bug, it is his property.
Err... true, but I'm sure Corgi has rules against decompiling/modifying his code. Might wanna check with him for permission first. As frustrated as I am with the bug, it is his property.
the code is fully available and under the LGPL-3.0 there is no need to decompile it and anyone should be fine to modify it as long as they comply with the terms of the License
I looked this over again and can't recreate the server stalling issue at all so I'm not sure how to go about profiling this. Someone with an already borked instance would need to use: https://visualvm.github.io/download.html and give me a screenshot of where it hangs
I've never used VisualVM before. I have reproduced the issue on a local host Fabric server. I'm not sure what part of VisualVM you need screenshots of, so please let me know if these screenshots are what you need. All screenshots are taken when the server refuses to stop.
Minecraft profile used for testing...
Fabric version: 1.20.1-0.16.8
Mods:
fabric-api-0.92.2+1.20.1
CorgiLib-Fabric-1.20.1-4.0.3.2
Oh-The-Biomes-Weve-Gone-Fabric-1.4.4
Oh-The-Trees-Youll-Grow-fabric-1.20.1-1.3.2
TerraBlender-fabric-1.20.1-3.0.1.7
owo-lib-0.11.2+1.20
geckolib-fabric-1.20.1-4.4.9
create-fabric-0.5.1-f-build.1417+mc1.20.1
@Coolkc456 i'd need the sampler tab specifically, expand the "Config file watcher"? Bc that looks like a culprit
@CorgiTaco Is this what you mean?
yes! @Coolkc456
And nothing seems wrong so what's is making it hang.... hmmm
@CorgiTaco Would it help if I zipped up my entire profile and linked a download to it to see if you can reproduce it with the same profile?
@Coolkc456 yes
@CorgiTaco All you should have to do is double click the start.bat to launch the server and then type stop in the window to reproduce the error, at least on my end.
@Coolkc456 yeah i genuinely do not know what's going on here lol
Found the issue, related to: TheElectronWill/night-config#187
@Coolkc456 @simeonpfeiffer @Fauli1221 @Hinzy-Admin New version up with the fix
@Coolkc456 @simeonpfeiffer @Fauli1221 @Hinzy-Admin New version up with the fix
@CorgiTaco you can message me on discord at the.birb.horse or on mastodon at @[email protected] to claim the bounty
thank you so much for the fix