[1.16.3] Client crash when trying to access a players death history with /deathistory name
WhitePhant0m opened this issue · 8 comments
Bug description
title
Steps to reproduce the issue
- have a player die
- do /deathhistory playername
- crash
Expected behavior
no crash
Log files
Crash Log
Versions
- Minecraft version 1.16.3
- Forge version 34.1.24
- Mod version 1.1.2
Other mods
Listed in the crash log
As an addition to this, failing to open a corpse
deaths.zip
f064374d-dcd8-402a-bdd8-3b0e2b9d8259 is the UUID of the player whose inventory we weren't able to open.
I don't think I have custom translations, where would i check for one?
Not being able to open the death inv also seems to happen with my inv too, f83bd929-fbf0-4186-becb-658d676fcc42, the inv i'm unable to open is the largest one, dc655fcd-b650-4736-b660-7920eea14bc1.dat
https://paste.gg/p/wphant0m/7a75366069dd42878f95bf1d2269bbeb
Do you have any custom translations?
java.lang.IllegalArgumentException: Illegal pattern character 'f'
This crash is caused when the translation of gui.corpse.death_history.date_format is no valid date format.
I added a fallback if the translation is not valid, but you should check your Minecraft instance.
In the next version I added a log output that shows the actual translation of the date format.
So if you update to the next version, please send me your logs again.
As an addition to this, failing to open a corpse
Unfortunately I am not able to reproduce this issue.
Can you send me the contents of your deaths folder in your world directory?
Thank you!
[21Oct2020 13:41:21.154] [Render thread/ERROR] [corpse/]: Failed to create date format. This indicates a broken translation: 'gui.corpse.death_history.date_format' translated to yyyy/MM/dd HH:mm:ss
That's weird... It behaves exactly like it should, but throws an exception nevertheless.
I'll have to further investigate this, but it should work for you anyways.
The open inventory issue should now be fixed.
I can confirm that the crash no longer happens tho 👍
This crash is caused when the translation of gui.corpse.death_history.date_format is no valid date format.
Can you send me the complete logs of your client when using version 1.16.3-1.1.3 or newer?
I just added a fallback if the date formatting throws an error, but I added a log message that should show the cause of the issue.
You just have to open the death history GUI once. This logs the translation of this string.