[1.12.2] 2nd page of corpse can't be clicked over to on corpse in-world, but shows up in death history info.
TheUnderTaker11 opened this issue ยท 4 comments
FOR ANYONE FINDING THIS IN THE FUTURE, HERE IS A FIXED VERSION YOU CAN DOWNLOAD: https://github.com/TheUnderTaker11/corpse/releases/tag/FixRelease
It does NOT need to be fixed on the server, if a 1.12.2 server is running Corpse mod you can just install this on your client and the fix will work!
Please read the FAQ before submitting a bug report!
Bug description
Unable to access the 2nd page of my corpse sometimes. Here is a video showing my Corpse when it happened. https://youtu.be/ouJ-E-vxcww
When you pull out all items, the corpse will stay there forever (presumably it knows you are unable to access
I am on a Multiplayer Server.
Steps to reproduce the issue
- Install Corpse mod along with any other mod that could make the Corpse mod need to have more than 54 slots to hold all your death items (I use this mod I recompiled myself from Wearable Backpacks) https://drive.google.com/file/d/1hkEknhsCPeY-KVfu_SCPwHM871JVFt8q/view?usp=share_link)
- Put enough items in your inventory such that it will need 2 pages.
- Die so a corpse is generated
- Either unload the chunks or reload the world, the corpse will now never be able to despawn since you can access the page 2 items.
I did not test with other mods, but I assume any mod greatly increasing the number of items you have on death would break this.
Expected behavior
Be able to access the 2nd page on my corpse.
Log files
Please provide log files of the game session in which the problem occurred.
Logs pasted below. Nothing Corpse-mod related was output to latest.log
[16:04:48] [Server thread/INFO] [tfc]: Reverted doDaylightCycle to true as players are logged in. [16:05:02] [Server thread/INFO] [OpenMods]: openblocks.common.PlayerInventoryStore.onPlayerDeath(PlayerInventoryStore.java:304): Storing post-mortem inventory into C:\Users\jacob\Desktop\AT Launcher\servers\TechNodefirmacraft\.\world\data\inventory-Chocolate_Milkk-2022-11-29_16.05.02-death-0.dat. It can be restored with command '/ob_inventory restore Chocolate_Milkk Chocolate_Milkk-2022-11-29_16.05.02-death-0' [16:05:02] [Server thread/INFO] [net.minecraft.server.dedicated.DedicatedServer]: Chocolate_Milkk fell from a high place [16:05:02] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 6489ms behind, skipping 129 tick(s) [16:05:48] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2651ms behind, skipping 53 tick(s) [16:06:33] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2153ms behind, skipping 43 tick(s) [16:07:18] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2291ms behind, skipping 45 tick(s) [16:08:03] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2229ms behind, skipping 44 tick(s) [16:08:49] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2139ms behind, skipping 42 tick(s) [16:09:34] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2074ms behind, skipping 41 tick(s) [16:11:04] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2111ms behind, skipping 42 tick(s) [16:14:49] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2062ms behind, skipping 41 tick(s) [16:16:19] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2167ms behind, skipping 43 tick(s) [16:21:34] [Server thread/WARN] [net.minecraft.server.MinecraftServer]: Can't keep up! Did the system time change, or is the server overloaded? Running 2158ms behind, skipping 43 tick(s) [16:21:46] [Server thread/INFO] [FTB Utilities]: Chocolate_Milkk is now AFK
Versions
- Minecraft version 1.12.2
- Forge version 14.23.5.2860
- Mod version
Other mods
TechnodeFirmaCraft mods, with these exceptions
- OpenBlock gravestone block is disabled.
- Wearable Backpacks is using a re-compiled version that adds all
Screenshots (Optional)
Linked video already
Even if 1.12.2 is no longer supported, I would appreciate at the very least pointing me to where in the code this issue might stem from if I wanted to try and fix it myself. It's getting kind of annoying having to go into creative mode so often to get the items.
It seems to be an issue when the chunk with the corpse gets unloaded, it doesn't properly send corpse data to the client when re-loaded.
Couldn't reproduce it in singleplayer with just backpack/corpse mod, however leaving/rejoining the world caused the same issue.
Even more specifically, once I edit the code to remove the page limit in the GUICorpse class, you can see the next page(s) and get the items from them. (It's just that you can keep going past the number of pages that you actually have items in). So somehow the server is sending the wrong information about the number of slots in the Inventory Container for the corpse.
