Causes serious problems with Soul Bound
Dr-WeiAL opened this issue · 5 comments
Please read the FAQ before submitting a bug report!
Bug description
When using any mod that allows a player's item to not be affected by death drops, it will cause the player's item to simply disappear
This problem is not present in the single player game, it appears in the server side
Steps to reproduce the issue
- Use Soul Bound enchantment or Mom's Love to let players die without dropping items
- Death
- Then the player's item disappears
Expected behavior
It should not disappear
It should go back to the player
Log files
https://pastebin.com/i3Q0T6Eg
Versions
- Minecraft version 1.19.2
- Forge version 43.2.11
- Mod version 1.0.0
Other mods
AttributeFix-Forge-1.19.2-17.2.6
curios-forge-1.19.2-5.1.4.1
l2archery-1.2.5
l2artifacts-1.7.3
l2backpack-1.8.5
l2complements-1.4.7
l2library-1.9.7
l2weaponry-1.2.4
MaxHealthFix-Forge-1.19.2-8.0.1
MomLove-Forge-1.19.2-1.2.0
Screenshots (Optional)
Looks like these mods don't properly implement their handling of dropping/not dropping the items on death.
This mod just uses Forges LivingDropsEvent (https://github.com/henkelmax/corelib/blob/211d2ec174ae952e22fbab77c47ca0576cdbcf06/src/main/java/de/maxhenkel/corelib/death/DeathEvents.java#L44). If the item is in there it would technically be dropped.
I’m the author of the soul bound enchantment mod. I do use LivingDropsEvent and I specifically made sure it worked with Corpse. I will check again.
Here is my implementation
https://github.com/Minecraft-LightLand/L2Complements/blob/ee4e6433783c96dd296b11171eb29f0f7d892e83/src/main/java/dev/xkmc/l2complements/events/MagicEventHandler.java#L75
Yes I double checked. It works. This problem should be caused by other mods that interfere with living drop event.