CraftTweaker

CraftTweaker

151M Downloads

Mirrored recipes are mirrored on all axis

jaredlll08 opened this issue ยท 6 comments

commented

I don't actually know if this is unintended behaviour, but it is something that I feel needs addressing in general.
with vanilla, a "mirrored" recipe does:
image
image
but this does not work:
image

With one of our mirrored recipes however...

image
image

It is mirrored on both axis, I feel we should probably have an option to choose how it is mirrored

commented

does that happen on all versions?

commented

probably all versions of 1.13+ that support mirrored recipes.

I don't remember if it worked like this in 1.12

commented

In the interest of not breaking stuff, I feel the default should be as it currently is now, for all we know someone was relying on this being both ways.

The overload could totally have it at the start though, would be somewhat cleaner

commented

image
:|

commented

So the question is, should it act like this?

I was thinking about adding a param that would let you dictate how it is mirrored, would need to be after the functions though, but it would give you more control over if it is mirrored left to right, top to bottom or both

commented

should it act like this?

probably not, no

I was thinking about adding a param...

I was thinking the same lol, would also probably default to horizontal mirror rather than all mirror - the param could also be at the beginning before the output and all and have the default overload? i.e.,

recipes.addShapedMirrored("test1", MirrorType.VERTICAL, <minecraft:diamond>, ...);
recipes.addShapedMirrored("defaults", <minecraft:dirt>, ...); // defaults to MirrorType.HORIZONTAL