Improper Holder used for damage sources
pupnewfster opened this issue ยท 1 comments
Issue description
I am fairly certain that the holders used when creating damage sources are incorrect and not the desired holder type to be used. It seems that in all DamageSource
constructors vanilla passes Holder.Reference
impls instead of a Holder.Direct
. Passing a direct holder may lead to problems as they always return false in their is
implementations, which means if someone were to query is(TagKey)
or is(ResourceKey<DamageType>)
on the DamageSource
they would get false as the result.
Steps to reproduce
No response
Script used
N/A
The crafttweaker.log file
N/A
Minecraft version
Other
Modloader
Forge
Modloader version
47.0.45
CraftTweaker version
14.0.6
Other relevant information
MC version: 1.20.1
The latest.log file
N/A
Closed by c401dcd