CraftTweaker

CraftTweaker

151M Downloads

MineTweakerAPI.ijeiRecipeRegistry.removeRecipe not updating JEI

Matryoshika opened this issue · 3 comments

commented

Intro:

Please note, you will be treated exactly like any other person who submits a bug report, saying this, if you decide to delete this template entirely, your issue will be closed. If you do not provide relevant information when reporting an issue (for example having a script issue and not providing the scripts or the minetweaker.log file) this issue will be closed. you may now delete this section and continue on with the report.

Issue Description:

I'm working on adding native CraftTweaker support to my mod, Underworld, which has a rather simple trading-block. Give X, get Y.
When using MineTweakerAPI.ijeiRecipeRegistry.removeRecipe(), CraftTweaker does not update JEI as it should.
Where I am calling said method: MTMetamorphicTableRecipes L82

What happens:

MineTweakerAPI.ijeiRecipeRegistry.removeRecipe does not cause JEI to remove the recipe.

What you expected to happen:

That said method call would update JEI to remove the recipe.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

http://pastebin.com/2XsSP75e

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):

http://pastebin.com/yKuQ0dFX


Affected Versions (Do not use "latest"):

  • Minecraft: 1.10.2
  • Forge: 12.18.3.2185
  • Crafttweaker: 3.0.23
  • JEI: 3.14.7.416

Your most recent log file where the issue was present:

commented

The line should be in the action, also if you use a JEIRecipeWrapper you need to remove the wrapper

commented

That is odd.
removeRecipe(object) refers to the private removeRecipe(object, object.class)
which refers to the private removeRecipeUnchecked(T , IRecipeCategory), which calls wrapperMap.remove ö.Ö
Gonna have to step through and see why the wrapper isn't being removed.

commented

All good now.
Thanks for the help 👍