CraftTweaker

CraftTweaker

186M Downloads

[1.12] Newest update appears to have broken some addons

Girouxdudes opened this issue ยท 5 comments

commented

Issue description

The newest 1.12 update appears to have somehow broken a few addons (CTIntegration and Dialogue). I'm not sure if this is even something fixable on crafttweaker's side, but I figure I'd ask, since it seems neither of those mods are gonna update anymore, and they were working fine before the update.

Relevant log file excerpt below:

Failed to register class for cat.jiu.dialog.api.helper.DialogOperation, caused by java.lang.RuntimeException: already has a getter
Failed to register expansion for xyz.tcreopargh.ctintegration.cot.BaubleVanillaFactoryExpansion, caused by java.lang.NoClassDefFoundError: xyz/tcreopargh/ctintegration/cot/BaubleItemContent
Failed to register class for cat.jiu.dialog.element.Dialog, caused by java.lang.RuntimeException: already has a getter

Steps to reproduce

No response

Script used

N/A

The crafttweaker.log file

https://gist.github.com/Girouxdudes/79084a9dd4c813a1062b1839bdbfabeb

Minecraft version

1.12

Modloader

Forge

Modloader version

14.23.5.2860

CraftTweaker version

4.1.20.705

Other relevant information

No response

The latest.log file

https://gist.github.com/Girouxdudes/248eb0406378901b4d332ee9cf3cbfd3

commented

This is a log file with the previous version of CT
https://gist.github.com/Girouxdudes/627717527a552a1d1e13fc78ac5a218a

commented

So if you look in that log, you will find the error messages that are now being printed in the crafttweaker.log file on new versions, just that they have very little info attached.

Old New
already has a getter already has a getter
NoClassDefFoundError NoClassDefFoundError
already has a getter already has a getter

As you can see, the errors were always there, the new log location just provides more information as to what the issue actually is, and stops it from being lost in the sea of log spam in the latest.log file.

Unfortunately the only "fix" I can make here, is to undo the change that made logging better, which I don't think should be done.

commented

Ah, I see, that's my mistake then. Is there at least some way to prevent ct from filling up the game chat with the messages?

commented

You can use this, but it will hide all errors, even script ones https://docs.blamejared.com/1.12/en/AdvancedFunctions/Preprocessors/IKWIDPreprocessor/

commented

Can you try those mods on the previous version and upload the latest.log file please

The latest version just changed where the error gets logged, and gives more info, so they should have been having these issues before, just logging them to the wrong log file.