CraftTweaker

CraftTweaker

151M Downloads

[1.12] Server Crash

TheLimePixel opened this issue · 27 comments

commented

What happens:

When somebody tries to join a server they get a "Fatally missing block and items" error, while in singleplayer everything is fine. It only happens when CraftTweaker is installed.

What you expected to happen:

The player to connect and everything to work fine.

Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):

https://pastebin.com/inM7iSWp
https://pastebin.com/sm73HRfA

Minetweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):

https://pastebin.com/FPUphB6w - server
https://pastebin.com/X9MjUAZv - client


Affected Versions (Do not use "latest"):

  • Minecraft: 1.12
  • Forge: 14.12.1.2413
  • Crafttweaker: 12-4.0.1

Your most recent log file where the issue was present:

https://pastebin.com/RvxDPfDi

commented

It's a known bug and should be fixed in a future release. See #262

Edit: Correction, it's fixed in build 4.0.1. I had this problem yesterday but now it's fixed.

commented

Well that's why I reported this. Because I knew that that was fixed today.

commented

can I get the server log please (game log, not crafttweaker.log)

commented

https://pastebin.com/kgBUWNNZ
Hmm, seems to do with it messing up advancements. Apparently removing the rail recipe caused it. Before, I had problems with the Cauldron, but at least that was adding a recipe, so I simply changed the name to minecraft:cauldron to fix it. Is there no way to fix the advancements problem?

commented
commented

Forgot a Z at the end.

commented

Advancement errors as safe to ignore, as those check for recipes which don't exist anymore.
I'm not really sure what thing actually it is that is causing problems.
Can you try to remove the line that is adding/removing the recipe for the xu2 resonator?

commented

I can remove it, but because of random issue I cannot test it (for some reason no matter what happens my local host always works fine). I need someone else to test it.

commented

Wait? So you can log in but other people can't? Are those logs you provided from you while you were able to join the server or from the other people who weren't?

commented

Other people tested it on their local hosts multiple times and they got the crash. My local host simply acts like a singleplayer world, so no matter what multiplayer crash there is, caused by any mod to any one else's server, it never happens to me. It's pretty confusing and something that neither I can explain. If you're still confused just ignore what I said.

commented

You missed the important part of the question. From who are the log files? You or the people where it doesn't work?

commented

Everyone that tested it technically. I didn't even test it as, as I said, I cannot.

Tbh, I'm probably just doing something wrong with my local host.

commented

Anyways, back to the problem at hands. Why do you believe it's the Resonator causing it?

commented

Because that is the only line that is different between client and server in the crafttweaker.log

Another thing you could try is giving every recipe a name, and not let crt give them names automatically

commented

Did i really...? Hmm, I forgot to add names to my last minute recipes. Could that by itself be the problem?

commented

It can be a problem, but it certainly shouldn't be, as we added code that automatically assigns names based on the ingredients, and those should be exactly the same on the server and the client, so it doesn't really matter whether you add names or not

commented

Why did you say that the name was so important then?

commented

Because I am not very confident in the way I generate the names. If you add names to everything and that fixes it, then I know my way of creating the names is broken

commented

Ok, I guess we'll see tomorrow. I guess if it works, that will also be solving another issue.

commented

It looks like you don't have exactly the same scripts for the client and the server, this is required for the 1.12 crt

commented

We do... There are 2 pastebins because I have them as separate files in the scripts folder. They are the same on the client and server.

commented

Yeah, that did not fix it. I added names to then and removed the resonator recipe and it still does not work.

commented

What happens if you start the game with crt installed but no scripts at all?

commented

It's all fine then

commented

We're starting to test how the files do by themselves

commented

We figured it out. Apparently you shouldn't have a colon in the name

commented

Ye that makes sense, a colon is the separator between modid an recipe name, so having those in there might confuse the game.

Maybe we should add in a check to prevent it and replace it with some other character?