Removing a 1-input shaped recipe removes ALL 1-input shaped recipes
Robijnvogel opened this issue ยท 7 comments
Issue Description:
If I try to remove a Shaped Crafting recipe with one input item, all vanilla- and various other crafting recipes with one input item get removed as well.
What happens:
In my modpack, 40 recipes get removed. (22 out of which are vanilla recipes)
In Vanilla 22 recipes get removed.
You may notice that these recipes all have 1 input item. It's Iron and Gold Blocks, wooden Logs, wooden and stone Buttons, etc.
What you expected to happen:
I expected 1 recipe to get removed.
Script used (Please Pastebin or gist your script, posting an unpasted or ungist'd script will automatically close this issue):
recipes.removeShaped(<*>, [[<minecraft:iron_ingot>]]);
I am not using Pastebin for a script that is literally one line...
It doesn't actually matter which item you use, though.
crafttweaker.log file (Please Pastebin or gist your file, posting an unpasted or ungist'd file will automatically close this issue):
Removing Shaped recipes for <*>
22 removed
Affected Versions (Do not use "latest"):
- Minecraft: 1.12.2
- Forge: 2611 and 2747
- Crafttweaker: 1.12-4.1.9
- Using a server: No
Your most recent log file where the issue was present:
I don't see how this could be relevant
What may also be of note it that these recipes that are removed are actually shapeless recipes according to their jsons in the MC resources, leading me to believe that these 1-input recipes are somehow getting past this guard or the shaped recipe removal is incorrectly parsed as a shapeless recipe from the script.
Welp...
This seems to be caused by:
recipes.removeShapeless(<*>, [
nugget, nugget, nugget,
nugget, nugget, nugget,
nugget, nugget, nugget]);
This result was produced with the build of CraftTweaker you provided me: CraftTweaker2-1.12-4.1.9.491
I am going on a limb here and assume that recipes.removeShapeless(<*>, [<anything>]);
now removes quite a few random recipes as well.
For troubleshooting this, it would help to have this print statement on this line as well.
Confirmed:
These are the 403 recipes that are removed by recipes.removeShapeless(<*>, [<iron_ingot>]);
Most of them are from ic2. All of them are modded.
Edit: Note that immersiveengineering:metal_storage/iron_ingot_uncraft - 9xitem.immersiveengineering.metal@29 is the only recipe that this script is actually supposed to remove.
Hold on... The patch version that you proposed, @jaredlll08 may have fixed the initial issue, but now the (shaped) crafting recipe for the IC2 Tree Tap is gone. Input is 5 planks.
That may still be related to this issue. I will investigate this further. :)
EDIT: Apparently the IC2 Blast Furnace can't be crafted any more either...
@jaredlll08 so did that also fix the other issue that may have been caused by the fix of the first one?
Self-quote from Discord:
"I suspect that the ic2 recipes aren't removed so much as they just bug out. Their whole custom crafting recipe category is removed or something.
Actually, this suspicion is only underlined by the fact that the non-ic2 recipes that are removed include Thermal Expansion cover crafting, Immersive Engineering bullet crafting and Immersive Engineering shader-bag-opening. If I am not mistaken, all of these are custom crafting recipe categories.
The only removed crafting recipe that I am not sure about is Galacticraft's emergency kit."