CraftTweaker

CraftTweaker

Mods
151M Downloads

Server-side JEI hiding throws NPE during startup

kindlich opened this issue ยท 0 comments

commented

Intro:

On Servers, any call to the JEI Plugin's HideAction#apply method throws a NPE (can be seen in the forge log).

Issue Description:

The JEI mod doesn't seem to invoke any of the register methods and thereby JEIAddonPlugin.ingredientHelper remains unassigned. That's why this method throws the NPE in the end:

CraftTweaker/CraftTweaker2-MC1120-Mod-JEI/src/main/java/crafttweaker/mods/jei/JEIAddonPlugin.java

Lines 53 to 55 in edaf8c3

public static List<ItemStack> getSubTypes(ItemStack stack) {
return JEIAddonPlugin.ingredientHelper.expandSubtypes(Collections.singletonList(stack));
}

What happens:

NPE in server log, doesn't crash the server nor does it have any real effect on the game since those actions are applied at Available, but still worth to take a look at.
Lines 163-204 in the linked log (Linked below as well)

What you expected to happen:

Either don't apply JEI hides server-side or check if we need to update JEI integration.

Script used

Any hiding line, such as
mods.jei.JEI.hide(<minecraft:crafting_table>);

crafttweaker.log file

https://gist.github.com/kindlich/171096e1c45442b44f2030a3f94f8e58#file-gh_653_crt-log

Affected Versions (Do not use "latest"):

  • Minecraft: 1.12.2
  • Forge: 1.12.2-14.23.5.2768
  • Crafttweaker: 4.1.11 (Not yet fixed in dev as well)
  • Using a server: Yes.
  • If yes, does the client have the exact same scripts? Yes, but irrelevant for this issue.

Your most recent log file where the issue was present:

https://gist.github.com/kindlich/171096e1c45442b44f2030a3f94f8e58#file-gh_653_latest-log