CraftTweaker

CraftTweaker

151M Downloads

jei doesn't update after reloading

jaredlll08 opened this issue ยท 14 comments

commented

I'll know what this means when I get to it

commented

Try loading in postInit instead of server starting, add "before:JEI"
test it
make jei not reload on the first load

commented

Alrgiht I got a bit lost with the build system so I'll hand it off to you...
Found a couple other things:

  1. CraftTweaker should only reload JEI after all the addons get the postReload event, so they can make any changes before JEI reloads.
  2. minetweaker.mods.jei.JEI's JEIHideItemAction should always check for jeiHelpers != null and either do the action or add it to apply. That way it will handle things no matter when JEI is loaded. It should also implement the undo that way.
commented

Would that fix the problem though? Of it not reloading the first time

On Oct 26, 2016 2:34 AM, "mezz" [email protected] wrote:

Alrgiht I got a bit lost with the build system so I'll hand it off to
you...
Found a couple other things:
CraftTweaker should only reload JEI after all the addons get the
postReload event, so they can make any changes before JEI reloads.
minetweaker.mods.jei.JEI's JEIHideItemAction should always check for jeiHelpers
!= null and either do the action or add it to apply. That way it will
handle things no matter when JEI is loaded. It should also implement the
undo that way.

โ€”
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/jaredlll08/CraftTweaker/issues/69#issuecomment-256218241,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFS9xXwaGqsTeqD73PwlQCzNNyr0yutkks5q3qAtgaJpZM4KfHap
.

commented

I ended up moving JEI's loading to FMLLoadCompleteEvent because it's the last client-side loading event that still shows a progress bar. This should help make it compatible even with mods that do things in postInit.

commented

No, they're just separate things I ran into.

commented

As it stands now, JEI version 3.12.8.328 is the last one that works with recipes changed via CraftTweaker. Hopefully this gets resolved soon :)

commented

JEI now updates after reloading, but CraftTweaker must not reload JEI when it starts up.
This means doing most things before JEI in FMLLoadCompleteEvent.
Right now the CraftTweaker reload of JEI is causing some people to disconnect from servers because it takes too long.

commented

I can't even get on my server. I really hope this is fixed soon.

commented

Very excited about the prospect of a fix for this. This issue gets my vote!

commented

Any news on how the fix is coming?

commented

Any news on when people will stop badgering me about this fix?
IT IS COMING! I am working with @mezz to fix it, but he is doing finals, and I'm going away for a week, it will be fixed as soon as possible.

commented

It had been over a month since the comment before YOYOK's.


If the emails are a problem, lock the topic until you're back, maybe? Would also keep your comment about being away visible.

You're just gonna get more comments in the meantime. It's a high-priority issue.

commented

I understand it is high priority, but you need to understand, in that month, I had my finals until the 25th of November, half a month of not being able to work on it. After that, I decided to take a week break to relax after those exams, the past week I have been trying to fix it, after many failed attempts, I contacted mezz to find out if we could work something out, and he had his finals, so yea,i understand it is high priority, but so is my mental state.

commented