CraftTweaker

CraftTweaker

151M Downloads

JEI Category Removals Scripts No Longer Seem to Work

KAfable opened this issue ยท 9 comments

commented

Issue Description:

Scripts to remove JEI Categories no longer seem to work,

What happens:

Nothing

What you expected to happen:

JEI Categories like the Sag Mill to disappear.
image

Script used

https://gist.github.com/Vyraal1/9d157b61feb15419897c08b0baf5868c

crafttweaker.log file

https://gist.github.com/Vyraal1/507a26370637106735d7c1e96352e6db


Affected Versions (Do not use "latest"):

  • Minecraft: 1.12.2
  • Forge:2821
  • Crafttweaker: 4.1.16
  • Using a server: No

Your most recent log file where the issue was present:

https://gist.github.com/Vyraal1/e31b6c7398f9fa669cb9341479b13d48

commented

Does it work for any category?

Also did JEI update recently?

commented

Same pack as vyraal, we're on jei version:
jei_1.12.2-4.15.0.269 which is their latest listed for 1.12.2
released March 8th

Additionally categories we arent removing are not showing up. For instance, using that script vyraal provided the thermal expansion Energetic Infuser recipes are not showing up even though we do not issue a hide for it anywhere and have custom recipes added to it, the entire category is just mysteriously missing yet the machine works fine/recipes execute when tested.

commented

All category removals seem to be broken (for what it's worth, there are also category removals for mods that aren't in this small test instance such as HarvestCraft and there are no errors in the log about them).

These were JEI's last updates -
image

We usually tried to update to latest whenever possible, but only noticed this issue recently.

commented

I'm going to say report to JEI, I haven't changed anything on my side, and the JEI docs say my thing should work.

commented

also not sure if its related but since this started happening any custom items we've added with
mods.jei.JEI.addItem() are no longer showing up in jei, we are adding about 30 items and confirmed none are showing up now.

Reported to JEI as well here: mezz/JustEnoughItems#1521

commented

Right, it looks like CraftTweaker is trying to remove a category that does not exist:

[15:52:41] [Client thread/ERROR] [jei]: Sending runtime to plugin failed: class crafttweaker.mods.jei.JEIAddonPlugin
java.lang.IllegalArgumentException: Unknown recipe category: mekanism.chemical_injection_chamber
	at mezz.jei.recipes.RecipeRegistry.hideRecipeCategory(RecipeRegistry.java:704) ~[RecipeRegistry.class:?]
	at crafttweaker.mods.jei.JEIMod.lambda$applyActions$0(JEIMod.java:74) ~[JEIMod.class:?]
	at java.lang.Iterable.forEach(Unknown Source) ~[?:1.8.0_201]
	at crafttweaker.mods.jei.JEIMod.applyActions(JEIMod.java:74) ~[JEIMod.class:?]
	at crafttweaker.mods.jei.JEIAddonPlugin.onRuntimeAvailable(JEIAddonPlugin.java:50) ~[JEIAddonPlugin.class:?]
	at mezz.jei.startup.JeiStarter.sendRuntime(JeiStarter.java:222) [JeiStarter.class:?]
	at mezz.jei.startup.JeiStarter.start(JeiStarter.java:111) [JeiStarter.class:?]
	at mezz.jei.startup.ProxyCommonClient.loadComplete(ProxyCommonClient.java:136) [ProxyCommonClient.class:?]
	at mezz.jei.JustEnoughItems.loadComplete(JustEnoughItems.java:55) [JustEnoughItems.class:?]

@jaredlll08 can you catch exceptions when adding or removing categories, and show the error message in the crafttweaker.log?

The other option is for me to log it instead of throwing an exception, but I think it's better if it's handled on your side because we can make sure the script writer sees the issue.

commented

Ah!

I am usually pretty good about try catching those, but it seems I missed the try catch for everything involving hiding items/fluids/categories.

commented

Just a PSA: EiO by itself has a config option for force disabling their JEI categories, I learned in the issue that I referenced to here

commented

I have submitted a small PR to help fix this issue.