CraftTweaker

CraftTweaker

151M Downloads

CraftTweaker breaks /help

p455w0rd opened this issue ยท 3 comments

commented

Since you're implementing ICommand, you're required to override the compareTo method. MCServer.java#L150. When you do this, but don't actually do the required comparison, it breaks the /help command. I would have submitted a PR, but it likely would have been denied, This is why I am posting here.

This:

	@Override
	public int compareTo(ICommand o)
	{
		return 0;
	}

Should be:

	@Override
	public int compareTo(ICommand o)
	{
		return this.getCommandName().compareTo(o.getCommandName());
	}
commented

Never be scared to make a PR. I'm actually offended, by saying that a PR to me would have likely been denied, you are putting me on the same assholery level of Lex. the ONLY time I deny pull requests is if it is plain stupid (this is not), or if it could cause issues (this fixes issues).

Anyway, fixed in the java8 branch, thanks!

commented

I'm fairly sure, somewhere down the line, I have accepted a 1 line change
PR, like I said, I don't care about who makes it, what it doe or how small
or big it is, if it works, then I'll accept

On Nov 5, 2016 9:56 PM, "p455w0rd" [email protected] wrote:

Oh..i was saying that simply because of the size of the PR XD..nothing
against you personally :)

โ€”
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/jaredlll08/CraftTweaker/issues/80#issuecomment-258636703,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AFS9xf5H67OqlXH7adWF7q2RSPdTWT8Xks5q7N9RgaJpZM4KqM6K
.

commented

Oh..i was saying that simply because of the size of the PR XD..nothing against you personally :)