AutoModpack closing the game after an update causes crash-assistant to think the game crashed.

it claims minecraft crashed without a crash report.

https://www.curseforge.com/minecraft/mc-mods/automodpack

The issue is AutoModpack mod just calling System.exit(0);
Which is actually crash with exit code 0. Since none of normal Minecraft finishing logic is called and process is interrupted immediately. It can cause issues, like corrupting configs.

I contacted with devs, they may fix it on their end with normal ways of finishing minecraft, instead of bad killing process way.

If they decide to not, I'll fix it on my end.

I'm closing this, since they've fixed it in one commit and now it's just waiting to be released.

Hope to reopen this, exit code 0 means success, why would it be different here? lots of other mods do this and its very annoying.

Hope to reopen this, exit code 0 means success, why would it be different here? lots of other mods do this and its very annoying.

I know some crashes with exit code 0. Which mod is the issue? Also only parent processes can access exit code. Crash Assistant is a child process, not parent. Oses just doesn't provide a way to access exit code.
We could parse exit code from launcherlogs, but not all launchers logging it.

I haven't actually checked which mod was causing it to pop up every time. In general I think it would be better to not show the popup with exit code 0, not sure which edge case is worse though, showing the popup even when not necessary, or maybe missing a few crashes? Oh and also the intel microcode popup is a great idea, but for some reason on my system it fails to identify the current running microcode and just says 0x0 and pops up even though I have 0x12B which should be fine.

I haven't actually checked which mod was causing it to pop up every time. In general I think it would be better to not show the popup with exit code 0, not sure which edge case is worse though, showing the popup even when not necessary, or maybe missing a few crashes? Oh and also the intel microcode popup is a great idea, but for some reason on my system it fails to identify the current running microcode and just says 0x0 and pops up even though I have 0x12B which should be fine.

As for exit code 0, can you share your modlist? Anyways I have plans to make not starting on 0 exit code as option.
As for 0x0, can you answer some questions here: #43