
Mod logging loop trying to change gen type
Qu3rt opened this issue ยท 10 comments
I'm using this mod in conbination with the Create Cobblestone deepslate generators in my 1.20.1 forge server but the console keep logging for every working gen (normal cobblestone and deepslate) this:
Changing generator type from "none" to "createcobblestone:generator_types/cobblestone.json"
Trying to update generator type from "none" to "createcobblestone:generator_types/cobblestone.json"
This is not a problem for the players, but having multiple players using it makes the server console full of logs every second.
I will now try to find something in the source code.
Does it keep logging or does it only log when generators load in/are changed?
They log the first time when they are loaded after startup and every time when a player use them to generate cobblestone(get changed I think).
I think il migrate all non-error logs to a debug option thats disabled at default
Thanks, that would be amazing. Also thanks for this mod too, saves a lot of resources and it's just amazing.
In the new beta (1.4.4, should be safe to use as no core features have been used) I added this setting:
The beta also contains some fixes that reduced the amount of logs in general.
For forge client this results (with the debug option off) in the following log: https://mclo.gs/llxeDhX. The server log is similair: only errors are logged.
I will be uploading the release to modrinth later today, for now you can try out the build artifacts of the github actions run: https://github.com/StickyPiston-development/CreateCobblestone/actions/runs/12723411264
Modrinth approved the release:
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.4-beta+fabric-1.20.1-89
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.4-beta+forge-1.20.1-89
Oh, I'm so sorry. I didn't reply. Yes, the mod works fine and the logs can now be disabled. I don't know if you'll need this issue open since it's still trying to chage gen type every time but for my use, it's more then fixed, thank you so much.
Good to hear!
What it does when it says the type changed is loading data in so the generator knows what to generate. This data is stored in a nbt tag, and that only changes when really changed. (Generator type removed, clicker with block)
Because that data is read when minecraft reloads the block, the block does not need to continually read that nbt, but this does happen frequently with a lot of players/generators, but luckily nbt read is not very heavy.