Create Cobblestone

Create Cobblestone

Mods
676 Downloads

Data or config driven additions

Grimmspecter opened this issue ยท 13 comments

commented

It would be cool if we could add custom blocks to the generator either via a config(preferred) or via a data pack.
something like EXAMPLE
}
}
minecraft:stone
SU threshold #
outputamount:
outputtime:

ect ect that way it could be used for modpacks for greater customization then we could configure blocks and make more expensive blocks take a long time and with low output if we want

commented

In the new beta, included is the option to add generators using a datapack. See for example https://modrinth.com/datapack/create-cobblestone-deepslate-generators.
It only includes the option to add a generator for now but i will be changing this.

Modrinth
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta+fabric-1.20.1-56
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta+forge-1.20.1-56

commented

I also got the other stuff working: https://www.youtube.com/watch?v=c_1c3vrQKR8

The config for deepslate i used for showcase is:

{
  "block": "minecraft:deepslate",
  "stress": "1024",
  "ratio": "80000"
}

When a field is not in the json it will take the value from config.

commented

I would appreciate it if you could test if this is what you wanted and check for bugs.

Modrinth
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-2+fabric-1.20.1-59
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-2+forge-1.20.1-59

commented

Changelog:

  • empty generator is now the first in creative menu
  • all generators can now be disabled using datapacks
  • /datapack enable/disable now automatically updates generator types, allowing the hotswapping of datapacks
  • fixed crash with create liquid fuel
  • deepslate generators are now enabled with datapack by default

Downloads
Fabric: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-3+fabric-1.20.1-65
Forge: https://modrinth.com/mod/create-cobblestone/version/1.4.1-beta-3+forge-1.20.1-65
Example datapack: https://modrinth.com/datapack/create-cobblestone-deepslate-generators/version/1.4.1+1.20.1

commented

I would appreciate it if you could test if this is what you wanted and check for bugs.

I have a mod adding a volcanic rock and cobble from Terrestria via the new data API, and while it works fine on the integrated client/server, when using a discrete server, the client crashes on the first attempt to view the creative inventory.

The top of the stack looks like this (let me know if you need further info, but I'm guessing this is just a matter of the client mod not getting fully initialized).

java.lang.NullPointerException: Cannot invoke "net.createcobblestone.data.GeneratorType.getId()" because "net.createcobblestone.data.GeneratorType.NONE" is null
	at net.createcobblestone.index.RegistrateDisplayItemsGenerator.accept(RegistrateDisplayItemsGenerator.java:30) ~[createcobblestone-1.4.1-beta-3+fabric-1.20.1-65.jar:?]
	at net.minecraft.class_1761.method_47306(class_1761.java:101) ~[client-intermediary.jar:?]
	at net.minecraft.class_7706.method_47338(class_7706.java:2052) ~[client-intermediary.jar:?]
commented

Could you send the datapack and the full log?

commented

Log: https://mclo.gs/qIp7SiF

The datapack is bundled in a mod. I'll upload that or commit it to github or something, soon.

commented

Thank you, im working on it!

commented

I've confirmed it's fixed. Thanks!

commented

The fabric version is working now, but you need a github account to download it. i will publish it to modrinth once i get it working.

gh actions link: https://github.com/StickyPiston-development/CreateCobblestone/actions/runs/11709890769

commented

On fabric it works, forge will not work and will probably break your existing generators.