Create: Diesel Generators

Create: Diesel Generators

3M Downloads

Wood Chips crushing recipe issues + suggestions

Slimmeyy opened this issue · 2 comments

commented

Note: I'm aware that a lot of this is covered by the unofficial fix from #84, but that was marked as completed on March 6th and the latest version (released March 9th) does not include the fix from that issue.

Issues

  1. wood_chips_crushable_4 contains stairs, fences AND slabs despite stairs and fences already having their own crushing recipes. I'm assuming this is leftover from a 1.18 version of the mod where all these new overworld wood types didn't exist yet (Crimson and Warped did exist already though and should've been included), and all of these items had the same output of 3-4 Wood Chips.
  2. If that's the case, it's missing Mangrove, Cherry, Bamboo, Crimson, Warped and Chip Wood Slabs. This results in 0 Wood Chips when crushing any of those listed types instead of the expected 3-4. This tag also won't support Pale Oak from the 1.21 update, and doesn't support any modded wood types besides those from Quark and Biomes O' Plenty, which are manually included in this tag.
    2.1 If Chip Wood Slabs were included, they would output 3-4 Wood Chips per slab while only costing 2 Wood Chips to make.
  3. This recipe takes precedent over the stairs crushing recipe, resulting in fewer Wood Chips than expected when crushing the 6 included types of stairs (getting 3-4 instead of 5-6). This is probably because of the alphabetical order of the recipe files.

Fix: #84 fixes all 4 of these issues by using the tag minecraft:wooden_slabs and lowering the Wood Chip output of the Chip Wood Slab to 1-2.
Image

  1. wood_chips_crushable_8 contains Spruce Slabs instead of Spruce Planks, resulting in 0 Wood Chips when crushing Spruce Planks and 7-8 Wood Chips when crushing Spruce Slabs instead of the expected 3-4 from the above recipe.
  2. This recipe is missing Mangrove, Cherry, Bamboo, Crimson and Warped Planks as well as Chip Wood Block. This results in 0 Wood Chips when crushing any of those listed types instead of the expected 7-8. This tag also won't support Pale Oak from the 1.21 update, and doesn't support any modded wood types besides those from Quark and Biomes O' Plenty, which are manually included in this tag.
    5.1 If Chip Wood Blocks were included, they would output 7-8 Wood Chips per slab while only costing 4 Wood Chips to make.

Fix: #84 fixes all 3 of these issues by using the tag minecraft:planks and lowering the Wood Chip output of the Chip Wood Block to 3-4.
Image

  1. If Chip Wood Stairs had a Mechanical Saw crafting recipe (which they should), it would be another way to obtain infinite Wood Chips (cost 4 to make, outputs 5-6). Even though the normal crafting recipe doesn't have this issue (cost 24 to make, outputs 20-24), #84 does change the default value, but its output of 4-5 per stair is still higher than the cost of 1 Chip Wood Block.
    6.1 The same issue applies to Chip Wood Slabs but the ratio would be the same as crafting normally which I've already mentioned in issue 2.1 and is already fixed by the adjustment from #84.

Fix: if a Mechanical Saw recipe is added, change the output of crushing Chip Wood Stairs to 3-4 Wood Chips to align with the 1-to-1 crafting ratio of a Mechanical Saw recipe.


Suggestions

  1. All exclusively wooden items should have a chips crushing recipe too. From vanilla this includes logs and wood blocks (minecraft:logs), wooden fence gates (forge:fence_gates/wooden¹), wooden doors (minecraft:wooden_doors)², wooden trapdoors (minecraft:wooden_trapdoors)², wooden pressure plates (minecraft:wooden_pressure_plates), wooden buttons (minecraft:wooden_buttons), dead bushes³, crafting tables, composters, ladders, chiseled bookshelves, signs, chests, barrels, boats, sticks³ and wooden tools. There's a few more that are primarily made of wood if you want to include them and disregard their other materials, but I'm not gonna list those.
  2. Bamboo Mosaic, Bamboo Mosaic Stairs and Bamboo Mosaic Slabs don't have the typical minecraft:planks/minecraft:wooden_stairs/minecraft:wooden_slabs tags despite being 100% made of wood, resulting in 0 Wood Chips when crushing them. They'd have to be added through either direct block ID or a custom tag.
  3. Chip Wood Beam should be crushable for Wood Chips, as long as it outputs equal or fewer Wood Chips than it costs to craft. The fix from #84 outputs 5-6, which is an appropriate value.
  4. If all the above are deemed too much for a rogue feature that isn't used for any main part of the mod, then make it into its own separate mod and flesh out the Chip Wood set more. This way it'd be easier for other Create addons that predominantly use Wood Chips to list it as a dependency without having all of the main diesel generator stuff just kinda sitting there.
  5. The fences crushing recipe could use the minecraft:wooden_fences tag instead of the forge:fences/wooden tag, though I'm only really suggesting it for tag consistency. Both tags are compatible with wooden fences from all other mods (including Fabric mods - tested with the Azalea Wood Set mod and Sinytra Connector), so compatibility isn't an issue either way.

¹ There is no minecraft:wooden_fence_gates tag as vanilla Minecraft doesn't have any non-wooden fence gates. Using minecraft:fence_gates would allow non-wooden fence gates too if any mod added them.
² #84 does include these, but their outputs aren't in line with the amount of Wood Chips you get from all other recipes.
³ I know dead bushes turn into sticks when broken and that sticks can be turned into wood chips with a Mechanical Saw, but having the ability to throw both into a crusher would be nice.

Mod versions used:
Create 6.0.4
Diesel Generators 1.3.1

commented

All wodden items will have a recipe for wood chips in the next version
also the reason there are wood_chip_crushable_x tags, is because I was not able to find a way for chip wood blocks to be tagged minecraft:planks and all items tagged minecraft:planks, excluding chip wood blocks, be crushable. Turns out its quite simple, so all modded wooden items will work now.

commented

#161
I fix the infinity wood chip issue