Create Enchantment Industry

Create Enchantment Industry

17M Downloads

Unable to apply Enchantments as expected

Soaryn opened this issue ยท 4 comments

commented

Minecraft Version

1.20.1

What Mods Conflicts with

Apotheosis

Describe the Incompatibility

I was hoping that the hyper enchanting would allow for automatically applying an enchantment regardless of its level. With or without the additional benefits of Hyper enchanting there seems to be odd behaviour

There are two noticeable problems:
First, by using normal experience, with an efficiency V book, I get, as expected, an efficiency V netherite pickaxe.
With hyper experience I get efficiency IV
image So somewhere the calculation for the hyper xp boosts are lost.

Second, if I try to apply an efficiency IX book the pickaxe gets skipped and pushed down the line without enchanting
image

Other Mods

Apotheosis

Additional Context

I tried with both hyper experience and normal
image

While I can see the problems that could arise from just letting the book determine the level (ping ponging back and forth between enchant/disenchant to re-enchant, it would be nice to be able to have this provided through a data pack for what enchantments level should be. A recommendation for that is to gather all the registered values (say multiple mods set in a json that efficiency's max value) and take the highest. This way both mod makers and pack makers could make a conscious choice for how they need the balancing to work without having a rigid config setting.

Crash Report or Log

No response

Mod Version

create_enchantment_industry-1.20.1-for-create-0.5.1.e-1.2.6.d.jar

Incompatible Mod Version

Apotheosis-1.20.1-7.0.5.jar

Forge Version

47.1.47

commented

About first problem:
From the screenshot you given, with hyper experience you get efficiency VI instead of IV, which is expected behavior.
About second problem:
Could you please provide debug.log? If Apotheosis compat failed it will be depicted in debug.log.

commented

About first problem: From the screenshot you given, with hyper experience you get efficiency VI instead of IV,

I can read........ MY BAD! I honestly thought in all of my checks even posting it was IV ...

Could you please provide debug.log? If Apotheosis compat failed it will be depicted in debug.log.

[05Oct2023 15:37:49.611] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [CHAT] <Soaryn> MAKE PICK
[05Oct2023 15:37:56.781] [Server thread/DEBUG] [plus.dragons.createenchantmentindustry.EnchantmentIndustry/]: Failed to load EnchHooks from Apotheosis, fall back to vanilla method...
[05Oct2023 15:37:59.893] [Server thread/INFO] [net.minecraft.server.MinecraftServer/]: [Not Secure] <Soaryn> End-----------------------
[05Oct2023 15:37:59.896] [Render thread/INFO] [net.minecraft.client.gui.components.ChatComponent/]: [CHAT] <Soaryn> End-----------------------
commented

Reflect fails on newest version. That's strange....
I'll check it. Thanks for reporting.

commented

OK fixed!