Create Enchantment Industry

Create Enchantment Industry

13M Downloads

Pump outflow should be updated regularly, rather than only when flow stops

brianfreud opened this issue ยท 6 comments

commented

I'm using create_enchantment_industry-1.18.2-for-create-0.5.0.e-1.0.0; see Creators-of-Create/Create#4138 for why I'm not yet using a newer version of Create. I have a pump set up with a fluid tank full of liquid experience. I have the pump set up so I can power it either using rotation controlled via a clutch, or a hand crank. Essentially, an Exp shower next to my enchanting area. Everything works, but the exp clump doesn't get created until I either stop turning the crank, or switch on the clutch, stopping the outflow from the pump. I essentially have to guess as to when to stop the flow. It'd be a lot more satisfying to be able to see the exp clumps get created (and absorbed) as the pump flows, so I can see the levels flow in.
Screenshot from 2022-12-14 19-01-33

commented

My apologies. I was just using the "shower" and noticed that orbs are generating as it flows, they're just generating such that they're stuck until the flow shuts off. The invisible 'flowing liquid' block that exists in front of a pipe when it is flowing (where the particles originate) seems to be preventing the orbs from falling while the flow is on.

That's almost certainly a Create issue, rather than anything that could be done here.

Screenshot from 2022-12-16 18-40-08

commented

at which time it seems to calculate the total amount of exp that leaked, and create the orb.

Calculation is finished instantly.
I cannot reproduce 'the exp orb does not seem to get created at all until the flow stops' in my environment. I think I might missed some information. Can you pleas tell me how to make it?

commented

Basically I cannot understand what you are asking for and where the bug is.
The experience leaking behavior is an implementation using built-in leaking function of Create itself. Thing should work as intended.

commented

It does leak. However, the exp orb isn't actually created until the leak is ended. With water or lava, when you have a leak, it does take a couple of seconds before you start seeing water or lava, but you do see it after a few seconds, even when the pipe continues to flow out. In the case of liquid experience, however, the exp orb does not seem to get created at all until the flow stops, at which time it seems to calculate the total amount of exp that leaked, and create the orb. That works, but it'd be more expected and satifying if orbs were created as the pipe flows out, while the flow continues.

commented
  1. Turn on rotation to power the pump (manual hand crank or from an engine, doesn't matter which)
  2. The "leaking" particle animation will start
  3. No orbs will appear
  4. Turn off power to the pump
  5. Now a single orb appears containing all of the leaked experience.

I'm suggesting moving #5 to be multiple orbs at point #3, so the exp is regained incrementally, rather than lump sum all at the end.

commented

I get what you mean. It's intended behavior of Create itself.
Firstly, when fluid reaching a leaking point, particle animation starts to appear, and at this moment the fluid doesn't "reach" the leaking point. It takes time for fluid "to flow through pipe" (simple simulation done by Create) and finally "reach next pipe or leaking point".

And about this:

5.Now a single orb appears containing all of the leaked experience.

I think it might because you didn't close that pump in time so there is still a leaking orb. I just tried to reproduce what you said about "exp is regained incrementally" but I didn't see any wrongly calculated value.