Create Enchantment Industry

Create Enchantment Industry

17M Downloads

Correct the xp to liquid xp ratio

th3impasta opened this issue ยท 3 comments

commented

Describe the your request

the xp to liquid xp ratio is currently 1:1
the standard ratio is actually 1 xp to 20 mb liquid xp
if this is unfixed, it could lead to xp dupes

commented

Could you please explain what is "standard ratio" and where it from?

commented

The ratio is from CoFH, the developers of the thermal suite. in line 176 of github.com/CoFH/CoFHCore-1.12-Legacy/blob/1.12/src/main/java/cofh/core/init/CoreProps.java it defines the xp to liquid xp ratio as 1 xp to 20 mb.

commented

1.A ratio from another mod is definitely not a "standard" which we should follow.
2.The example you gave is from a 1.12 mod.
3.Most importantly, It doesn't lead to dupe problem. Different implementation of liquid experience.