Incompatibility with all mods that add special shafts and encased cogwheels
hlysine opened this issue ยท 2 comments
Describe the bug
This is similar to #75 but with an expanded scope. The current code of Extended Cogwheels causes a lot of incompatibility with other mods due to the way it patches commonly used renderers/instances, assuming that Create's cogwheels are the only blocks that use those renderers.
First, the patch on BracketedKineticBlockEntityRenderer assumes that all blocks that use such a renderer (except Create's original shaft) are cogwheels. This breaks all modded shafts with special functions, such as special shafts in Create Encased and shear pins in Create: Connected.
Second, the patch on EncasedCogRenderer forces casings to be rendered, which causes z-fighting on add-on blocks that use this renderer but have block models.
In general, I don't think it is a good idea for Extended Cogwheels to patch these commonly re-used renderers. There should at least be checks to make sure that only Create's blocks are modified, but a better way to implement this is to add a new block type for cogwheels in other material types, so that the effect is limited to blocks that Extended Cogwheels explicitly support. If this is too much work, an API from Extended Cogwheels for us to disable the patches would also be nice.
To Reproduce
Steps to reproduce the behavior:
Install Create: Extended Cogwheels with any mods that add special shafts/encased blocks.
Expected behavior
Create: Extended Cogwheels should not change the rendering of blocks from other mods.
Loader & Other Mods:
- Forge
- Create: Connected
Additional context
Note: I am the developer of Create: Connected.
I've found that disabling Flywheel's renderer can fix this, but obviously that's not a very good fix performance-wise.
I'm surprised there still hasn't been a fix for this yet, it's been a few months...
