Create Fabric

Create Fabric

10M Downloads

ThreadLocalRandom accessed from a different thread

purejosh opened this issue ยท 5 comments

commented

Describe the Bug

Loglines showing that Create isn't being threadsafe.

Reproduction Steps

Use create with something that requires threasafe, like C2ME.

Expected Result

Be threadsafe.

Screenshots and Videos

No response

Crash Report or Log

https://gist.github.com/purejosh/a17fea67d60698ac58204fcb32816f50

Operating System

n/a

Mod Version

0.5.1b

Minecraft Version

1.19.2

Other Mods

No response

Additional Context

No response

commented

Closing since i cant reproduce and doesnt seem like a create/porting lib bug

commented

I'm pretty sure it is, I need to investigate the relevant code

commented

The relevant code no longer exists.

commented

Thanks!

commented

This seems like it should be reported to C2ME, its crashing at Bee.this.level.random.nextInt(10); which is in a vanilla class and this would eventually get called anyway if mc places structures from a different thread(?)