Crash with KubeJS when placing down a Basin
skippyall opened this issue ยท 5 comments
Describe the Bug
When placing down a Basin with KubeJS installed, the game crashes with this crash report. (Issue on KubeJS: KubeJS-Mods/KubeJS#697)
crash-2023-09-06_16.04.17-client.txt
Reproduction Steps
- Install Create and KubeJS
- Place down a Basin
Expected Result
The Basin to be placeable like normal
Screenshots and Videos
No response
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1d
Minecraft Version
1.20.1
Other Mods
KubeJS 2001.6.3-build.23
Additional Context
No response
Note we don't modify anything about Create nor Fabric's transfer API, so I'm at a loss as to why this issue should be stemming from KubeJS' end? Maybe porting-lib or Create Fabric isn't up to speed with a new (breaking) change in Fabric Transfer API?
I got an other crash report in my modpack where this issue first occured to me. Maybe this is more helpful (although this can't be well reproduced) crash-2023-09-08_09.48.35-server.txt
I found the problem: ItemStackHandlerContainer from Porting Lib both extends from ItemStackHandler and implements Container. KubeJS' ContainerMixin injects an interator() method (inherited from InventoryKJS) and Porting Lib's ItemStackHandler inherits another iterator() method, so that Java doesn't know which one to call.
