Create Fabric

Create Fabric

10M Downloads

Broken advancements after updating from 1.18.2 to 1.19.2

RareScrap opened this issue ยท 4 comments

commented

Describe the Bug

After replacing create-fabric-0.5.0.i-1016+1.18.2.jar with create-fabric-0.5.1-b-build.1089+mc1.19.2.jar I faced A LOT (368) of missing advancements.

I don't want my players to lose they advancements. So I think this bug may lead to progression losses on servers and singe player worlds after update.

Reproduction Steps

  1. Setup a Minecraft 1.18.2 dedicated fabric server
  2. Install create-fabric-0.5.0.i-1016+1.18.2.jar on the server and client
  3. Join server
  4. Give all advancements to player using /advancement grant @a everything
  5. Shutdown server
  6. Update the server to 1.19.2
  7. Install create-fabric-0.5.1-b-build.1089+mc1.19.2.jar on the server and client
  8. Join server with 1.19.2 client
  9. See a console madness

Expected Result

All advancements recognize correctly

Screenshots and Videos

No response

Crash Report or Log

https://pastebin.com/n5SxY2Ui

Operating System

CentOS 7

Mod Version

0.5.1d

Minecraft Version

1.20.1

Other Mods

No response

Additional Context

No response

commented

Bump

commented

advancements were changed. not a bug

commented

advancements were changed. not a bug

So I can safely remove them and this wouldn't affect the user's progress?

commented

Data migration tool won't be provided. Based on Discrord discussion (starts here):

keeping progress doesn't make sense
-- Tropheus Jay

And honestly it'd probs be a waste of time to data fixer advancements
-- IThundxr || Steam 'n' Rails

Moreover, you will most likely face this issue during version update:

You updated from 1.18 -> 1.19
2 very different versions so this is kinda expected
-- IThundxr || Steam 'n' Rails

So you have several options:

  1. Drop unrecognized advancements (IMHO, it's not so bad because players will lose only craft recipes)
  2. Manually migrate broken advancements like this:
    In 0.5.0.i there was such an advancement:
"create:recipes/create.palettes/cut_diorite_bricks_from_diorite_stonecutting": {
    "criteria": {
      "has_diorite": "2023-08-30 02:41:37 -0400"
    },
    "done": true
  },

And in 0.5.1.b it's changed to this:

"create:recipes/create.palettes/cut_diorite_bricks_from_stone_types_diorite_stonecutting": {
    "criteria": {
      "has_stone_types_diorite": "2023-08-30 02:41:37 -0400"
    },
    "done": true
  },
  1. Develop and maintain your own custom datafixer

Hope the development team will value their player data more in the future.