Create Fabric

Create Fabric

11M Downloads

[Patch F] Train Observer Crash

JensenJ opened this issue ยท 2 comments

commented

Describe the Bug

Hi, I'm running the latest commit fb322c8 and I imported a singleplayer world from 0.5.1d to see if any crashes or issues occur. Noticed that when train observer saves it's NBT a crash occurs.

Reproduction Steps

  1. Place down train observer linked to track in singleplayer
  2. Try to go to main menu to force world save.
  3. Crash

Expected Result

No crash

Screenshots and Videos

No response

Crash Report or Log

https://mclo.gs/qjjG4z9

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.20.1

Other Mods

It's the dev environment, so whatever was in that commit.

Additional Context

No response

commented

Probable cause is that FilterItem#test was replaced by with FilterItemStack#test

commented

The issue is that it used to pass a ItemStack before and now it passes a FilterItemStack which doesn't extend ItemStack we should be able to use FilterItemStack.item() to which will fix this, will make a pr soon