Create Fabric

Create Fabric

Mods
11M Downloads

millstone producing wrong item counts, including vanilla recipes

Abalieno opened this issue ยท 2 comments

commented

Describe the Bug

As written already on discord, if a millstone has a chanced output and its count is higher than 1, the actual produced output ignores the count and always returns only 1.

create-fabric-0.5.1-c-build.1160+mc1.19.2

Reproduction Steps

As above, tested with vanilla data\create\recipes\milling\charcoal.json

Expected Result

Item count not being ignored.

Screenshots and Videos

uilou;

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.1f

Minecraft Version

1.19.2

Other Mods

No response

Additional Context

No response

commented

Looking more into this, it looks like the count is being counted, but as a random range.

With a count of 4 I get mixed results of 1-4. As if it takes count as a range.

I still don't think this is the way it's meant to work, even if at least it's not truly game breaking.

commented

Seems to be intended, I was pointed to this:
https://github.com/Creators-of-Create/Create/blob/d66170c8fed5d02ad46f44fd0e66685be88a3170/src/main/java/com/simibubi/create/content/processing/recipe/ProcessingOutput.java#L50-L60

The conclusion is that the counts are indeed variable, but they should average to the same ratio, and so over time the output ends up balanced.