Fluid pipes drop brackets when waterlogged
AzaSad opened this issue ยท 2 comments
Describe the Bug
Fluid pipes drop his brackets when waterlogged, but they are still visible in the model
Reproduction Steps
1.Place a fluid pipe
2.Place a bracket
3.Waterlog the pipe
Expected Result
The fluid pipe should keep the bracket when waterlogged, or the bracket should stop being visible when dropped
Screenshots and Videos
FluidPipeBug.mp4
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.1f
Minecraft Version
1.20.1
Other Mods
No response
Additional Context
i think the problem is the onStateReplaced method on the FluidPipeBlock class
exactly this part
if (state != newState && !isMoving)
removeBracket(world, pos, true).ifPresent(stack -> Block.dropStack(world, pos, stack));
i ask, why would it be needed, since i think the only instance in which the fluid pipe state gets replaced is when waterlogged, right?
Indeed changing those two lines seem to fix the issue (Sorry for closing and reopening, this is my first time submitting an issue in github)
