Create Fabric

Create Fabric

10M Downloads

KubeJS compat and better tags

StockiesLad opened this issue ยท 27 comments

commented

Describe the Suggestion

I was trying to get create to work with other mods' ores, ingots etc. Things like getting the crushing wheel to properly process other ores. All the trial and error to no avail. My concern is that since create (fabric) uses forge tags, it doesn't work at all with anything else besides vanilla. I already assume you guys are aware of this and I'm curious about the plans of mitigation.

Screenshots and Videos

No response

Additional Context

No response

commented

oh ok thanks!

commented

Any plans to have fabric support in your mod addon.

commented

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

commented

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

quilt is very buggy. I'm building from source anyways so it's all good.

commented

[B#744] Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on port_lib$clientStartTickEvent could not find any targets matching 'Lnet/minecraft/class_1657;tick()V' in net.minecraft.class_1657. Using refmap porting_lib-refmap.json [PREINJECT Applicator Phase -> porting_lib.mixins.common.json:PlayerMixin from mod porting_lib -> Prepare Injections -> -> handler$zeg000$port_lib$clientStartTickEvent(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]

It spits out this error when I use the compiled version.

how you compile?

commented

Any plans to have fabric support in your mod addon.

It's easy to port(you can port yourself or use Quilt. Most of Fabric mods can play on Quilt.

quilt is very buggy. I'm building from source anyways so it's all good.

note that the source doesn't include createplus-core(datapack) by default.

commented

[B#744] Caused by: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException: Critical injection failure: @Inject annotation on port_lib$clientStartTickEvent could not find any targets matching 'Lnet/minecraft/class_1657;tick()V' in net.minecraft.class_1657. Using refmap porting_lib-refmap.json [PREINJECT Applicator Phase -> porting_lib.mixins.common.json:PlayerMixin from mod porting_lib -> Prepare Injections -> -> handler$zeg000$port_lib$clientStartTickEvent(Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V -> Parse]

It spits out this error when I use the compiled version.

commented

I changed the port lib hash to the new one.

commented

createplus don't need port lib and you can use the latest version of create fabric directly.

commented

I was talking about ur PR of create

commented

oh i saw...

commented

fetched upstream

commented

fetched upstream

Is it getting merged now? Or is it already merged.

commented

?

commented

latest.log
It causes a porting lib issue tho...

commented

Player Mixin is failing

commented

if you want it to work with other mods, I'd think that editing the base tags yourself would be viable, seeing as none of this is hardcoded

commented

try CreatePlus.
https://modrinth.com/mod/createplus
it can fix issue about tags.

commented

try CreatePlus. https://modrinth.com/mod/createplus it can fix issue about tags.

#245
Pull Request about this

commented

Oh wait, its for quilt exclusively...
Does it really have to be exclusive for quilt?

commented

try CreatePlus. https://modrinth.com/mod/createplus it can fix issue about tags.

trying it now.

commented

if it's a mixin issue, report it to TropheusJ

commented

if it's a mixin issue, report it to TropheusJ

ok

commented

KubeJS support: https://www.curseforge.com/minecraft/mc-mods/kubejs-create
we will be handling tags with the 1.19 update.

commented

pog

commented

tag change happened