Create Fabric

Create Fabric

10M Downloads

Commented out player entity check causes crash if blocks are placed by non-player entity

skylorbeck opened this issue · 7 comments

commented

This commented out check causes a crash if a modded entity places blocks see: skylorbeck/MageHand#8

commented

How…

commented

Heads up, this bug is back and the code is commented out again.

commented

Also this code is commented out in every branch I could find.

commented

This event only listens for players placing blocks. If non-players placing is crashing, it's a separate issue and I'd still like to see the log and maybe fix it.

commented

looking at this again, this is not an issue. The comment could be removed, but my fix was a null check a few lines down, which is still present. If something is crashing, it's a separate issue.

commented

Okay well I guess having support for nonplayer entities placing blocks isn't important then. I'll be sure to pass that onto all my users who crash because of it.