Create Fabric

Create Fabric

10M Downloads

Incorrect culling with More Culling installed

StockiesLad opened this issue · 8 comments

commented

Describe the Bug

it doesnt render the blockface that it is sitting on, despite being a transparent

Reproduction Steps

1.use this modpack: https://www.technicpack.net/modpack/the-limit-reborn-1181.1905659
2.update create (remove addons that are outdated)
3.issue
...

Expected Result

To render normally

Screenshots and Videos

Uploading image.png…

Crash Report or Log

https://gist.github.com/FluffyBumblebees/3fefc9ab56db82adfc5dd53a888f95af

Operating System

Win 10

Mod Version

0.5.0c

Minecraft Version

1.18.2

Other Mods

Listed on the modpack page

Additional Context

it's not shaders, tested without it

commented

It is more culling

commented

image

commented

Ok so this is due to the culling shape of the track being a flat box. The call to getOcclusionShape() returns the culling shape of the track, its not used so getShape() is used instead. As you can see here it then gets the correct voxel for this track.
The Voxel leads to here where you can see its just a flat box.
This is not the correct culling shape based on what the track looks like.

There are multiple ways to fix this:

  1. Use the correct culling shape. This can help other rails next to the rail cull!
  2. Use the block tag: moreculling:dont_cull
  3. Use the moreculling API to set cantCullAgainst() to prevent culling against the block while still allowing the rails to cull themselves against other blocks

If you do option 3, you can also use the API to set customShouldDrawFace() so that the rails cull against themselves.
Otherwise please set isSideInvisible to do that.

With a long rail setup, culling these faces can really help out

commented

Ok so this is due to the culling shape of the track being a flat box. The call to getOcclusionShape() returns the culling shape of the track, its not used so getShape() is used instead. As you can see here it then gets the correct voxel for this track. The Voxel leads to here where you can see its just a flat box. This is not the correct culling shape based on what the track looks like.

There are multiple ways to fix this:

  1. Use the correct culling shape. This can help other rails next to the rail cull!
  2. Use the block tag: moreculling:dont_cull
  3. Use the moreculling API to set cantCullAgainst() to prevent culling against the block while still allowing the rails to cull themselves against other blocks

If you do option 3, you can also use the API to set customShouldDrawFace() so that the rails cull against themselves. Otherwise please set isSideInvisible to do that.

With a long rail setup, culling these faces can really help out

I'll KJS the blocktag for a temp fix

commented

mod incompatibility, try to narrow it down

commented

Add this to low priority for now

commented

Ok, I'd guess indium/sodium but I'll test once create additions is updated (so that my modpack doesnt break)

commented

Seems to already be fixed