Create Fabric

Create Fabric

Mods
10M Downloads

OpenGL shader compilation error on Mesa (Linux Intel/AMD)

ryndinol opened this issue ยท 1 comments

commented

Describe the Bug

Regression in recent commit 5cfe04c for shader crash that was fixed in upstream Create.

[21:01:53] [Render thread/INFO] (com.mojang.blaze3d.platform.GlDebug) OpenGL debug message: id=3, source= SHADER COMPILER, type=ERROR, severity=HIGH, message='0:69(1): error: #extension directive is not allowed in the middle of a shader'
[21:01:53] [Render thread/ERROR] (com.jozufozu.flywheel.backend.Backend) Shader compilation log for create:rotating: 0:69(1): error: #extension directive is not allowed in the middle of a shader

Only fails on Intel/AMD graphics on Linux.
Upstream commit of fix:
Creators-of-Create@67bcbc8

Regression in this commit:
5cfe04c#:~:text=if%20defined(GL_ARB_conservative_depth)-,%23,-extension%20GL_ARB_conservative_depth%20%3A%20enable

Reproduction Steps

  1. Checkout 5cfe04c or later on Linux running Intel/AMD graphics.
  2. ./gradlew clean runClient --no-daemon
  3. See shader compilation error in log
  4. delete #extension GL_ARB_conservative_depth : enable in src/main/resources/assets/create/flywheel/shaders/context/contraption.glsl (it's already included in #use "flywheel:context/fog.glsl" I think)
  5. recompile, runs in-game as expected.

Expected Result

...

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Void Linux (mesa-21.2.6_1)

Mod Version

0.4.0a

Minecraft Version

1.18.1

Other Mods

No response

Additional Context

No response

commented

speedrun