The menu button is missing, when used with mods, that add their language files to minecraft namespace

Question

The menu button is missing, when used with mods, that add their language files to minecraft namespace

SplendidAlakey opened this issue 2 years ago · 16 comments

SplendidAlakey commented 2 years ago

Describe the Bug

The Create menu button is missing on 1.19.2, if any mod, that adds its own language files into the minecraft namespace, is also present.

Reproduction Steps

Install this build on Fabric
Install a mod, that adds its own language files to the minecraft namespace, e.g. Incendium, BetterBiomeBlend, Consistency+.
Run the game

Expected Result

There should be a menu button.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0f

Minecraft Version

1.19.2

Other Mods

Incendium
BetterBiomeBlend
Consistency+

Additional Context

~~The issue is exclusive to Fabric, Quilt is unaffected.~~

TropheusJ commented 2 years ago

???

JieningYu · Answer 1 · 2022-11-14T10:23:31.000Z

weird. Incendium is just a jarred datapack.

AlphaMode · Answer 2 · 2022-11-14T10:32:01.000Z

The mod is closed source can't really do anything

SplendidAlakey · Answer 3 · 2022-11-14T10:45:50.000Z

The mod is closed source can't really do anything

Yeah, figured as much. Should I keep the issue open for visibility or nah?

Skidamek · Answer 4 · 2022-11-14T12:44:06.000Z

Incendium is completely server-side, you can just remove it from client

SplendidAlakey · Answer 5 · 2022-11-14T12:50:44.000Z

I'm not playing on a server, though.

Skidamek · Answer 6 · 2022-11-14T13:26:26.000Z

Makes sense

Skidamek · Answer 7 · 2022-11-14T13:32:47.000Z

However becouse Incendium mod is just a jarred datapack as JieningYu said, you can try to use a normal datapack version of Incendium https://www.planetminecraft.com/data-pack/incendium-nether-expansion/

JieningYu · Answer 8 · 2022-11-14T13:39:22.000Z

No. there's a class in that mod

AkashiiKun · Answer 9 · 2022-11-14T13:51:01.000Z

The class is just an event registry which does nothing.
(Blurred something as I'm not supposed to use a decompiler)

And the only class is for forge.
Also, it doesn't even have the seed fix as is already in the vanilla game. So definitely with using the datapack is enough.

JieningYu · Answer 10 · 2022-11-14T14:45:23.000Z

so.. why Incendium can cause that?

SplendidAlakey · Answer 11 · 2022-11-14T15:13:21.000Z

It's caused by their language files somehow. I was wrong in my initial claim, that Quilt is unaffected by this bug, I just had my Incendium jar bootleg "patched". I moved their language files out of minecraft namespace to it's own to avoid a bug with Minekea. But I just tested a clean Incendium jar on Quilt and the bug occurred.

SplendidAlakey · Answer 12 · 2022-11-14T15:29:28.000Z

I updated the issue to reflect the actual bug: the menu button disappears, if another mod adds its own language files to minecraft namespace. Removed the logs, because there's nothing in them anyway.

I've experienced a similar issue before with Minekea, except, in their case, blocks have broken translation strings: chimericdream/minekea-fabric#67

TropheusJ · Answer 13 · 2022-11-14T15:32:25.000Z

Issue is probably this line

SplendidAlakey · Answer 14 · 2022-11-17T07:06:08.000Z

Not fixed. The issue became worse after the patch (build 766), the button now doesn't appear at all, no mods, en_us game language. But this time, the logs do seem to mention a related error: https://gist.github.com/SplendidAlakey/c2ad83bc17cbb5e3b7ea04cddddab941

TropheusJ · Answer 15 · 2022-11-18T01:14:32.000Z

Super weird. I've encountered this issue before with Consistency+. Somehow having lang in the vanilla namespace makes translations just not work at the stage the button is added.

Share to