Extended reach is incorrect with Pehkui
ERBEpic opened this issue ยท 2 comments
Describe the Bug
When having Pehkui installed, the extendo grip attack range only gets extended by one block. Without Pehkui, it is extended to 3.
Reproduction Steps
- Install Pehkui
- Install Create
- Attempt to use Extendo Grip past normal attack range
Expected Result
The extendo grip extends attack range as normal
Screenshots and Videos
left is extendo without Pehkui, middle is extendo with Pehkui, and right is normal fist.
Crash Report or Log
No response
Operating System
Windows 10
Mod Version
0.5.0g
Minecraft Version
1.19.2
Other Mods
No response
Additional Context
I also have made an issue on Pehkui, as i was told to make an issue for both mods.
Create uses Reach Entity Attributes to extend the player's reach. This library and Pehkui do not interact properly.
Pehkui does have compat code for Reach Entity Attributes.
However, looking at the ExtendoGripItem, it seems it's using just the ReachEntityAttributes.REACH attribute, which only affects block reach. It should also make use of the ReachEntityAttributes.ATTACK_RANGE attribute. (similarly on the Forge version, it's only using ForgeMod.REACH_DISTANCE and not also ForgeMod.ATTACK_RANGE)