Create Fabric

Create Fabric

10M Downloads

Issues with BlockPlaceCallback cause glue effect particles even when no block is placed

TropheusJ opened this issue · 2 comments

commented

Describe the Bug

On forge, the block place event is fired after a block is placed, then giving listeners the option to rollback.
On fabric, we test if we can place via listeners, and then place.
This causes glue to spawn particles even when no block has been placed.

Reproduction Steps

  1. place glue in offhand
  2. place lever in main hand
  3. place lever
  4. click block lever is on, not the lever itself. notice the glue particles appearing.

Expected Result

Glue particles will not appear

Screenshots and Videos

image

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.4.0b

Minecraft Version

1.18.1

Other Mods

No response

Additional Context

No response

commented

promoted to Feature™️

commented

You'd think the event differences would be significant, but the particles are actually the only way this affects gameplay. Doesn't even take durability. Not worth the major change for some particles.