Create Fabric

Create Fabric

10M Downloads

Funnel extracts from wrong side (SidedStorage)

aria1th opened this issue ยท 0 comments

commented

Describe the Bug

see FunnelTileEntity 's Line 228.

It refers 'getOpposite', but as you know, SidedStorage extracts from facing itself.

I.E. Funnel is attached to block's facing east.

If block offers 'east' access, then we find storage with this:

ItemStorage.SIDED.find(blockEntity.getWorld(), blockEntity.getPos().offset(side), side.getOpposite()),

but in current implementation, it will find from 'opposite side' with correct position.

Reproduction Steps

Using Tech reborn's storage unit, which offers configurable sided inventory,

2023-02-12_21 34 30

  1. set Slot configuration which offers 'west' side.
  2. attach funnel on 'east' side (facing east)
  3. Item should not be able to extracted, actually correct side should be 'west'.

Expected Result

But, item extracts. In other case, if funnel is attached in correct side, item won't be extracted.

Tech reborn's storage is just simple and configurable example.

All custom SidedInventory access that blocks normal inventory access, will show incorrect behavior.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 11

Mod Version

0.5.0i

Minecraft Version

1.19.2

Other Mods

No response

Additional Context

No response