Create Fabric

Create Fabric

10M Downloads

Fluid pumps can't extract out of Hephaestus Scorched Duct (and possibly all sided fluid provider)

StealthyKamereon opened this issue ยท 1 comments

commented

Describe the Bug

When making a foundry of the mod Hephaestus, Create pumps can't extract the selected fluid if the fluid isn't at the bottom of the foundry (in the controller's gui).
This breaks all multi-fluid contraptions.

Reproduction Steps

  1. Install Create-fabric with Hephaestus
  2. Make a foundry and fill it with two different liquids
  3. Use a scorched duct to filter one of the liquid and try to pump it with a mechanical pump

Expected Result

The filtered liquid you always be extracted.
In my test, the filtered liquid could only be extracted if it's the lowermost liquid in the foundry controller gui.

Screenshots and Videos

No response

Crash Report or Log

No response

Operating System

Windows 10

Mod Version

0.5.0i

Minecraft Version

1.18.2

Other Mods

  • Hephaestus Fabric

Additional Context

Luckily, I was able to investigate further :)

The bug showed up after I updated the version of the modpack Create Astral from 2.0.3b to 2.0.4c.
Thanks to that I was able to have a reproductible setup where I could just swap one mod and check the result.

1. Confirm that this mod is indeed the root cause

As I said I had a setup with everything working ie no bug in create-fabric-0.5.0.i-944+1.18.2

I've tried several versions of each mod installed :

  • Changing version of Hephaestus didn't change the behaviour.
  • Using Forge + Create did resolve the issue

From that I can say for sure the fabric port is causing the bug.

2. Narrowing down the root cause

Before posting this issue I've looked to find any relevant linked issue and found #909 .
That issue describe a bug similar and a range of version that is relevant with mine.

Using github builds numbers I was able to diff the code.

For what I understand, I would say that this new test is preventing the pump from extracting out of sided fluid provider.

I hope I have given you every bit of information necessary and that's you'll be able to fix it quickly :)

commented

The bug occured with Fabric version 0.14.14.
I tested with Fabric 0.14.19 and the same version of all the mods and it works fine.