Overriding base Create registrations
falxie opened this issue ยท 10 comments
What happened?
I somewhat randomly got an error that blamed create_jetpack with the message java.lang.RuntimeException: Unexpected error while registering entry create:schematicannon to registry minecraft:item and java.lang.IllegalArgumentException: Unknown registration schematicannon for type ResourceKey[minecraft:root / minecraft:block].
Looking at the debug logs it seems like this mod is overriding a lot of create's own registrations.
Mod Version
1.3.1
Minecraft Version
No response
Forge Version
40.1.74
Relevant log output
[30Aug2022 01:24:15.708] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create_jetpack:jetpack to registry minecraft:block
[30Aug2022 01:24:15.708] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registering 560 known objects of type minecraft:block
[30Aug2022 01:24:15.709] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `schematicannon`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.709] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:schematicannon to registry minecraft:block
[30Aug2022 01:24:15.709] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `schematic_table`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.709] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:schematic_table to registry minecraft:block
[30Aug2022 01:24:15.710] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `shaft`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.710] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:shaft to registry minecraft:block
[30Aug2022 01:24:15.711] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `cogwheel`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.711] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:cogwheel to registry minecraft:block
[30Aug2022 01:24:15.711] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `large_cogwheel`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.711] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:large_cogwheel to registry minecraft:block
[30Aug2022 01:24:15.711] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `andesite_encased_shaft`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.713] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:andesite_encased_shaft to registry minecraft:block
[30Aug2022 01:24:15.713] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `brass_encased_shaft`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.713] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:brass_encased_shaft to registry minecraft:block
[30Aug2022 01:24:15.713] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `andesite_encased_cogwheel`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.713] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:andesite_encased_cogwheel to registry minecraft:block
[30Aug2022 01:24:15.713] [Render thread/INFO] [net.minecraftforge.registries.GameData/]: Potentially Dangerous alternative prefix `create` for name `brass_encased_cogwheel`, expected `create_jetpack`. This could be a intended override, but in most cases indicates a broken mod.
[30Aug2022 01:24:15.713] [Render thread/DEBUG] [com.tterrag.registrate.AbstractRegistrate/REGISTRATE.REGISTER]: Registered create:brass_encased_cogwheel to registry minecraft:block
I believe this is caused by Create Jetpack using Create's CreateRegistrate.lazy which binds event listeners within Create's mod context, causing an overlap and breaking the context system.
I do think so too, it's still a bit weird because it does not happen every time
If it helps I can provide a WIP version of my modpack where I'm running into this issue
The warnings in my debug.log are always there, the crashes are less common. https://github.com/PssbleTrngle/CreateJetpack/releases/tag/1.3.2 still has the same warnings in my debug.log.
This is somewhat related, but I also get a CME from Create when this mod is installed, likely because it's reusing AllSoundEvents from Create.
CreateJetpack/src/main/kotlin/com/possible_triangle/create_jetpack/Content.kt
Lines 134 to 137 in 6c63270