Create Jetpack

Create Jetpack

10M Downloads

Jetpack pressure display breaks diving helmet air display

xbxbxb123 opened this issue · 9 comments

commented

What happened?

When using the jetpack underwater with the diving helmet, the air tank timer fluctuates along with the visual indicator in the top left corner of the screen.
I believe this is caused by the visual indicator changing the actual remaining capacity of the tank to provide one of its visual effects

Mod Version

1.3.2

Minecraft Version

1.18

Forge Version

40.1.75

Relevant log output

No response

commented

Thanks, I am not quite sure why that happens but I will look into it

commented

If you mean that the timer is ticking down quicker (a bit uneven) than it normally would, that makes sense, because that's exactly what's happening. The timer is calculated using the remaining air and the amount of air used by the diving helmet every tick, but as soon as you use additional air via the jetpack (for example in hover mode), or any other air consuming tool like the extendo-grip, the timer skips a few seconds.

I am not sure how you could "solve" this, because I do not think this is a bug, everything is working exactly as it should. It would also not be possible to include the air used by the jetpack in this calculation, because I would have to predict what the user would do in the future.

commented
commented

Do you mean the timer on the bottom right oscillates or the visual indicator for the jetpack on the to left?
Because the jetpack indicator is meant to blink while it is consuming air

commented
commented

That's just a coincidence, the timer on the left simply blinks because that is how I choose to represent that the tank is being drained. The timer on the bottom has a small jump everytime air is being drained, which makes sense, but as far as I could see, it only jumps a few seconds down, not up

commented
commented

I've recorded a video of the bug, it definitely happens.
https://youtu.be/4b6G-lAR84E

commented

I think this might be a bug with Create's code to display the air timer and not just for this mod, but the jetpack usage exaggerates it.