Create Railways Navigator

Create Railways Navigator

Mods
2M Downloads

Major Server Breaking Bug in Regex Resolving Stations

TheKayneGame opened this issue ยท 1 comments

commented

Version:

  • Minecraft Version: 1.21.1
  • NeoForge Version 21.1.172
  • Mod Version beta-0.8.1

Describe the bug
Server Crashes and lands in a Crashloop when Setting destination station <Something..>**
This may happen on accident

To Reproduce
Steps to reproduce the behavior:

  1. Open Train Schedule.
  2. add stop
  3. set stop to prioritised destination.
  4. set any of the stops to a station name with double wildcards (**)
  5. apply
  6. Close
  7. set as train schedule
  8. Crash
  9. restart server
  10. As soon as PrioritizedDestinationInstruction.start is called, crash
  11. Go to 9

Expected behavior
The exception not to crash the server and:
Disallow me from submitting this erroneous string.
Silently ignore this string.
Sanitise the string.

Screenshots
None

Additional context
Log Dump
https://mclo.gs/CgAcPNA

Most likely cause being

Create-Train-Navigator/common/src/main/java/de/mrjulsen/crn/data/schedule/instruction/PrioritizedDestinationInstruction.java

Line 173 in e44062f

if (!regex.matcher(globalStation.name).matches()) {

Not catching any exceptions.

commented

should be fixed in the latest update