Createsifter crashes when CraftTweaker but not CreateTweaker is installed
Witixin1512 opened this issue ยท 3 comments
Describe the Bug
Createsifter has a soft dependency on CraftTweaker through CrT's plugin system. However, at the same time, it uses CreateTweaker classes without ever checking if it is installed at all.
Also, Createsifter uses an incorrect namespace for its plugin, should be createsifter:sifter
By the same rules, it should not be using CraftTweaker's namespace to create RecipeComponents.
Additionally, the recipe components should have a sensible name that explains what they're used for, such as "is_waterlogged" or "minimum_speed".
The dumpToCommandString method located here does not return what is expected of it. This method should return the required script line to replicate that recipe within a script.
The https://github.com/CraftTweaker/CraftTweaker-Addon-Template repository as well as CraftTweaker's implementation for vanilla managers and handlers should server as examples.
If you have any questions or doubts feel free to drop by the CraftTweaker discord!
Reproduction Steps
- Install CreateSifter and CraftTweaker (but not CreateTweaker
- The game crashes during CrT's plugin configuration.
Expected Result
The game should not crash when CreateTweaker is not installed, since Createsifter has no hard dependency on it.
CreateSifter also should NOT be using Createtweakers namespace for its CraftTweaker plugin.
Screenshots and Videos
No response
Crash Report or Log
Operating System
Windows 11
Mod Version
1.20.1-1.8.1.e-22
Minecraft Version
1.20.1
Forge Version
47.2.4
Other Mods
CraftTweaker
Additional Context
No response
This issue has been marked as stale because it has been inactive for 3 weeks. It will be closed if it remains inactive for another 3 weeks.
